From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3154 invoked by alias); 11 Jan 2008 20:17:22 -0000 Received: (qmail 3137 invoked by uid 9657); 11 Jan 2008 20:17:20 -0000 Date: Fri, 11 Jan 2008 20:17:00 -0000 Message-ID: <20080111201720.3135.qmail@sourceware.org> From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools vgsplit.c Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00019.txt.bz2 CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2008-01-11 20:17:19 Modified files: tools : vgsplit.c Log message: Refactor vgsplit for accepting existing vg as destination Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgsplit.c.diff?cvsroot=lvm2&r1=1.41&r2=1.42 --- LVM2/tools/vgsplit.c 2007/11/15 21:59:11 1.41 +++ LVM2/tools/vgsplit.c 2008/01/11 20:17:18 1.42 @@ -239,6 +239,14 @@ CORRECT_INCONSISTENT | FAIL_INCONSISTENT))) return ECMD_FAILED; + if ((active = lvs_in_vg_activated(vg_from))) { + /* FIXME Remove this restriction */ + log_error("Logical volumes in \"%s\" must be inactive", + vg_name_from); + unlock_vg(cmd, vg_name_from); + return ECMD_FAILED; + } + log_verbose("Checking for new volume group \"%s\"", vg_name_to); if ((vg_to = vg_lock_and_read(cmd, vg_name_to, NULL, LCK_VG_WRITE | LCK_NONBLOCK, @@ -249,13 +257,6 @@ return ECMD_FAILED; } - if ((active = lvs_in_vg_activated(vg_from))) { - /* FIXME Remove this restriction */ - log_error("Logical volumes in \"%s\" must be inactive", - vg_name_from); - goto error; - } - /* Set metadata format of original VG */ /* FIXME: need some common logic */ cmd->fmt = vg_from->fid->fmt;