public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/reporter.c Date: Sun, 20 Jan 2008 01:23:00 -0000 [thread overview] Message-ID: <20080120012347.6882.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2008-01-20 01:23:46 Modified files: . : WHATS_NEW tools : reporter.c Log message: Fix pvs, vgs, lvs error exit status on some error paths. (note -o help is now considered error) Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.773&r2=1.774 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/reporter.c.diff?cvsroot=lvm2&r1=1.33&r2=1.34 --- LVM2/WHATS_NEW 2008/01/19 12:36:37 1.773 +++ LVM2/WHATS_NEW 2008/01/20 01:23:46 1.774 @@ -1,5 +1,6 @@ Version 2.02.32 - =================================== + Fix pvs, vgs, lvs error exit status on some error paths. Version 2.02.31 - 19th January 2008 =================================== --- LVM2/tools/reporter.c 2008/01/07 20:42:57 1.33 +++ LVM2/tools/reporter.c 2008/01/20 01:23:46 1.34 @@ -240,13 +240,13 @@ opts = arg_str_value(cmd, options_ARG, ""); if (!opts || !*opts) { log_error("Invalid options string: %s", opts); - return 0; + return EINVALID_CMD_LINE; } if (*opts == '+') { if (!(str = dm_pool_alloc(cmd->mem, strlen(options) + strlen(opts) + 1))) { log_error("options string allocation failed"); - return 0; + return ECMD_FAILED; } strcpy(str, options); strcat(str, ","); @@ -273,8 +273,10 @@ if (!(report_handle = report_init(cmd, options, keys, &report_type, separator, aligned, buffered, - headings))) - return_0; + headings))) { + stack; + return ECMD_FAILED; + } /* Ensure options selected are compatible */ if (report_type & SEGS) @@ -284,7 +286,7 @@ if ((report_type & LVS) && (report_type & PVS) && !args_are_pvs) { log_error("Can't report LV and PV fields at the same time"); dm_report_free(report_handle); - return 0; + return ECMD_FAILED; } /* Change report type if fields specified makes this necessary */
next reply other threads:[~2008-01-20 1:23 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-01-20 1:23 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2010-06-17 13:15 mbroz 2007-02-14 15:18 agk 2007-01-27 2:09 agk 2004-05-24 14:14 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080120012347.6882.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).