public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/merge.c Date: Fri, 22 Feb 2008 13:22:00 -0000 [thread overview] Message-ID: <20080222132246.11092.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2008-02-22 13:22:45 Modified files: . : WHATS_NEW lib/metadata : merge.c Log message: Fix remove_layer_from_lv to empty the LV before removing it. (2.02.30) Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.796&r2=1.797 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/merge.c.diff?cvsroot=lvm2&r1=1.34&r2=1.35 --- LVM2/WHATS_NEW 2008/02/22 13:22:19 1.796 +++ LVM2/WHATS_NEW 2008/02/22 13:22:44 1.797 @@ -1,5 +1,6 @@ Version 2.02.34 - =================================== + Fix remove_layer_from_lv to empty the LV before removing it. (2.02.30) Add missing no-longer-used segs_using_this_lv test to check_lv_segments. Remove redundant non-NULL tests before calling free in clvmd.c. Avoid a compiler warning: make is_orphan's parameter const. --- LVM2/lib/metadata/merge.c 2008/01/30 14:00:00 1.34 +++ LVM2/lib/metadata/merge.c 2008/02/22 13:22:44 1.35 @@ -224,6 +224,20 @@ seg->le + seg->len - 1, seg_found); r = 0; } + + seg_found = 0; + list_iterate_items(seg2, &seg->lv->segments) + if (sl->seg == seg2) { + seg_found++; + break; + } + if (!seg_found) { + log_error("LV segment %s:%" PRIu32 "-%" PRIu32 + "is incorrectly listed as being used by LV %s", + seg->lv->name, seg->le, seg->le + seg->len - 1, + lv->name); + r = 0; + } } if (le != lv->le_count) {
next reply other threads:[~2008-02-22 13:22 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-02-22 13:22 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-06-09 19:36 mbroz 2008-01-26 0:30 agk 2007-07-10 18:50 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080222132246.11092.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).