public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: ccaulfield@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW daemons/clvmd/clvmd.c Date: Fri, 09 May 2008 09:59:00 -0000 [thread overview] Message-ID: <20080509095939.24865.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: ccaulfield@sourceware.org 2008-05-09 09:59:39 Modified files: . : WHATS_NEW daemons/clvmd : clvmd.c Log message: Fix uninitialised mutex in clvmd if all daemons are not running at startup. Thanks to Mark Hlawatschek for pointing this out. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.871&r2=1.872 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd.c.diff?cvsroot=lvm2&r1=1.45&r2=1.46 --- LVM2/WHATS_NEW 2008/05/09 07:20:04 1.871 +++ LVM2/WHATS_NEW 2008/05/09 09:59:39 1.872 @@ -1,5 +1,6 @@ Version 2.02.38 - ================================= + Fix uninitialised mutex in clvmd if all daemons are not running at startup. Make clvmd-cman use a hash rather than an array for node updown info. Check lv_count in vg_validate. Add --prefixes to reporting tools for field name prefix output format. --- LVM2/daemons/clvmd/clvmd.c 2008/03/28 12:58:09 1.45 +++ LVM2/daemons/clvmd/clvmd.c 2008/05/09 09:59:39 1.46 @@ -530,7 +530,7 @@ char nodename[max_cluster_member_name_len]; clops->name_from_csid(csid, nodename); - DEBUGLOG("PJC: checking for a reply from %s\n", nodename); + DEBUGLOG("Checking for a reply from %s\n", nodename); pthread_mutex_lock(&client->bits.localsock.reply_mutex); reply = client->bits.localsock.replies; @@ -541,7 +541,7 @@ pthread_mutex_unlock(&client->bits.localsock.reply_mutex); if (!reply) { - DEBUGLOG("PJC: node %s timed-out\n", nodename); + DEBUGLOG("Node %s timed-out\n", nodename); add_reply_to_list(client, ETIMEDOUT, csid, "Command timed out", 18); } @@ -985,6 +985,14 @@ } } + /* Initialise and lock the mutex so the subthread will wait after + finishing the PRE routine */ + if (!thisfd->bits.localsock.threadid) { + pthread_mutex_init(&thisfd->bits.localsock.mutex, NULL); + pthread_cond_init(&thisfd->bits.localsock.cond, NULL); + pthread_mutex_init(&thisfd->bits.localsock.reply_mutex, NULL); + } + /* Only run the command if all the cluster nodes are running CLVMD */ if (((inheader->flags & CLVMD_FLAG_LOCAL) == 0) && (check_all_clvmds_running(thisfd) == -1)) { @@ -1056,12 +1064,6 @@ thisfd->bits.localsock.pipe = comms_pipe[1]; - /* Initialise and lock the mutex so the subthread will wait after - finishing the PRE routine */ - pthread_mutex_init(&thisfd->bits.localsock.mutex, NULL); - pthread_cond_init(&thisfd->bits.localsock.cond, NULL); - pthread_mutex_init(&thisfd->bits.localsock.reply_mutex, NULL); - /* Make sure the thread has a copy of it's own ID */ newfd->bits.pipe.threadid = thisfd->bits.localsock.threadid;
next reply other threads:[~2008-05-09 9:59 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-05-09 9:59 ccaulfield [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-28 11:06 zkabelac 2012-02-28 9:58 zkabelac 2012-02-28 9:53 zkabelac 2012-02-27 11:26 zkabelac 2012-02-27 9:58 zkabelac 2011-10-11 9:54 zkabelac 2011-10-11 9:26 zkabelac 2011-09-16 14:40 mbroz 2011-08-11 12:57 mbroz 2011-06-28 13:42 zkabelac 2011-03-30 12:36 zkabelac 2011-03-08 22:48 zkabelac 2011-03-08 13:27 mbroz 2010-12-13 10:49 prajnoha 2010-12-01 12:41 zkabelac 2010-12-01 10:46 zkabelac 2010-04-06 15:29 ccaulfield 2010-02-02 8:54 ccaulfield 2009-10-12 8:33 ccaulfield 2009-09-01 9:48 ccaulfield 2009-08-13 10:39 ccaulfield 2009-03-24 11:49 ccaulfield 2008-11-21 13:48 ccaulfield 2008-06-13 7:44 ccaulfield 2008-03-28 12:58 ccaulfield 2008-03-17 9:37 ccaulfield 2008-02-15 14:12 meyering 2007-11-15 10:16 pcaulfield 2007-03-29 13:59 pcaulfield 2006-12-11 13:48 pcaulfield 2006-11-30 9:44 pcaulfield 2005-04-01 13:01 pcaulfield 2005-02-08 9:05 pcaulfield 2005-01-24 15:31 pcaulfield 2005-01-05 14:41 pcaulfield 2004-10-06 12:36 pcaulfield 2004-10-06 10:12 pcaulfield
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080509095939.24865.qmail@sourceware.org \ --to=ccaulfield@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).