public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools lvm.c lvmcmdline.c Date: Tue, 03 Jun 2008 17:48:00 -0000 [thread overview] Message-ID: <20080603174813.15733.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2008-06-03 17:48:13 Modified files: tools : lvm.c lvmcmdline.c Log message: suppress warning on silent failure with ECMD_PROCESSED Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvm.c.diff?cvsroot=lvm2&r1=1.106&r2=1.107 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvmcmdline.c.diff?cvsroot=lvm2&r1=1.64&r2=1.65 --- LVM2/tools/lvm.c 2008/05/30 15:27:44 1.106 +++ LVM2/tools/lvm.c 2008/06/03 17:48:13 1.107 @@ -236,7 +236,7 @@ log_error("No such command '%s'. Try 'help'.", argv[0]); - if (ret && !error_message_produced()) { + if ((ret != ECMD_PROCESSED) && !error_message_produced()) { log_debug("Internal error: Failed command did not use log_error"); log_error("Command failed with status code %d.", ret); } --- LVM2/tools/lvmcmdline.c 2008/05/30 15:27:44 1.64 +++ LVM2/tools/lvmcmdline.c 2008/06/03 17:48:13 1.65 @@ -1099,7 +1099,7 @@ if (!strcmp(argv[0], "quit") || !strcmp(argv[0], "exit")) break; ret = lvm_run_command(cmd, argc, argv); - if (ret) { + if (ret != ECMD_PROCESSED) { if (!error_message_produced()) { log_debug("Internal error: Failed command did not use log_error"); log_error("Command failed with status code %d.", ret); @@ -1227,7 +1227,7 @@ if (ret == ENO_SUCH_CMD) log_error("No such command. Try 'help'."); - if (ret && !error_message_produced()) { + if ((ret != ECMD_PROCESSED) && !error_message_produced()) { log_debug("Internal error: Failed command did not use log_error"); log_error("Command failed with status code %d.", ret); }
reply other threads:[~2008-06-03 17:48 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080603174813.15733.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).