public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/vgcfgbackup.c Date: Wed, 13 Aug 2008 12:44:00 -0000 [thread overview] Message-ID: <20080813124424.6581.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2008-08-13 12:44:24 Modified files: . : WHATS_NEW tools : vgcfgbackup.c Log message: Fix vgcfgbackup to properly check filename if template is used. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.945&r2=1.946 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgcfgbackup.c.diff?cvsroot=lvm2&r1=1.24&r2=1.25 --- LVM2/WHATS_NEW 2008/08/05 14:29:38 1.945 +++ LVM2/WHATS_NEW 2008/08/13 12:44:23 1.946 @@ -1,5 +1,6 @@ Version 2.02.40 - ================================ + Fix vgcfgbackup to properly check filename if template is used. configure aborts if lcov or genhtml are missing with --enable-profiling vgremove tries to remove lv snapshot first. Added function lv_remove_with_dependencies(). --- LVM2/tools/vgcfgbackup.c 2008/01/30 14:00:02 1.24 +++ LVM2/tools/vgcfgbackup.c 2008/08/13 12:44:24 1.25 @@ -34,8 +34,7 @@ dm_free(filename); return NULL; } - if (*last_filename && !strncmp(*last_filename, filename, - strlen(template))) { + if (*last_filename && !strncmp(*last_filename, filename, PATH_MAX)) { log_error("VGs must be backed up into different files. " "Use %%s in filename for VG name."); dm_free(filename); @@ -70,7 +69,8 @@ return ECMD_FAILED; } - backup_to_file(filename, vg->cmd->cmd_line, vg); + if (!backup_to_file(filename, vg->cmd->cmd_line, vg)) + return ECMD_FAILED; } else { if (!consistent) { log_error("No backup taken: specify filename with -f "
reply other threads:[~2008-08-13 12:44 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080813124424.6581.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).