public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: mbroz@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW lib/report/report.c
Date: Fri, 06 Feb 2009 12:41:00 -0000 [thread overview]
Message-ID: <20090206124152.28686.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: mbroz@sourceware.org 2009-02-06 12:41:52
Modified files:
. : WHATS_NEW
lib/report : report.c
Log message:
Fix pvs segfault when pv mda attributes requested for not available PV.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1035&r2=1.1036
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/report/report.c.diff?cvsroot=lvm2&r1=1.94&r2=1.95
--- LVM2/WHATS_NEW 2009/02/04 12:47:05 1.1035
+++ LVM2/WHATS_NEW 2009/02/06 12:41:51 1.1036
@@ -1,5 +1,6 @@
Version 2.02.45 -
===================================
+ Fix pvs segfault when pv mda attributes requested for not available PV.
Add support for ext4 resize in fsadm
Move locking_type reading inside init_locking().
Rename get_vgs() to get_vgnames() and clarify related error messages.
--- LVM2/lib/report/report.c 2009/01/10 17:09:40 1.94
+++ LVM2/lib/report/report.c 2009/02/06 12:41:51 1.95
@@ -868,15 +868,14 @@
const char *pvid = (const char *)(&((struct id *) data)->uuid);
struct metadata_area *mda;
- info = info_from_pvid(pvid, 0);
-
- dm_list_iterate_items(mda, &info->mdas) {
- if (!mda->ops->mda_free_sectors)
- continue;
- mda_free = mda->ops->mda_free_sectors(mda);
- if (mda_free < freespace)
- freespace = mda_free;
- }
+ if ((info = info_from_pvid(pvid, 0)))
+ dm_list_iterate_items(mda, &info->mdas) {
+ if (!mda->ops->mda_free_sectors)
+ continue;
+ mda_free = mda->ops->mda_free_sectors(mda);
+ if (mda_free < freespace)
+ freespace = mda_free;
+ }
if (freespace == UINT64_MAX)
freespace = UINT64_C(0);
@@ -908,13 +907,12 @@
const void *data, void *private)
{
struct lvmcache_info *info;
- uint64_t min_mda_size;
+ uint64_t min_mda_size = 0;
const char *pvid = (const char *)(&((struct id *) data)->uuid);
- info = info_from_pvid(pvid, 0);
-
/* PVs could have 2 mdas of different sizes (rounding effect) */
- min_mda_size = _find_min_mda_size(&info->mdas);
+ if ((info = info_from_pvid(pvid, 0)))
+ min_mda_size = _find_min_mda_size(&info->mdas);
return _size64_disp(rh, mem, field, &min_mda_size, private);
}
next reply other threads:[~2009-02-06 12:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 12:41 mbroz [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-05-20 22:24 agk
2010-01-07 14:37 zkabelac
2009-01-10 17:09 agk
2009-01-10 15:04 wysochanski
2008-12-15 13:30 wysochanski
2007-01-22 15:07 agk
2007-01-18 17:48 agk
2006-10-02 16:46 agk
2004-05-05 18:23 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090206124152.28686.qmail@sourceware.org \
--to=mbroz@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).