public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/liblvm lvm_base.c Date: Tue, 10 Mar 2009 15:38:00 -0000 [thread overview] Message-ID: <20090310153847.18253.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2009-03-10 15:38:47 Modified files: liblvm : lvm_base.c Log message: Remove unnecessary includes in lvm_base.c. We would like to declare our handles pv_t, vg_t, and lv_t in the external library header lvm.h. However, these are already defined in metadata-exported.h for the use of some of the in-progress liblvm APIs. Thus, we cannot both define them in lvm.h and include metadata-exported.h in the external library C files. We could use preprocessor tricks (#ifndef) but for now we just avoid the include. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/liblvm/lvm_base.c.diff?cvsroot=lvm2&r1=1.1&r2=1.2 --- LVM2/liblvm/lvm_base.c 2009/03/06 16:19:53 1.1 +++ LVM2/liblvm/lvm_base.c 2009/03/10 15:38:46 1.2 @@ -16,8 +16,6 @@ #include "lvm.h" #include "toolcontext.h" #include "locking.h" -#include "metadata-exported.h" -#include "report.h" lvm_t lvm_create(const char *system_dir) {
next reply other threads:[~2009-03-10 15:38 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-03-10 15:38 wysochanski [this message] 2009-07-14 3:01 wysochanski 2009-07-27 21:02 wysochanski 2010-05-19 12:12 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090310153847.18253.qmail@sourceware.org \ --to=wysochanski@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).