public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/metadata.c Date: Wed, 22 Apr 2009 09:31:00 -0000 [thread overview] Message-ID: <20090422093133.12921.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2009-04-22 09:31:32 Modified files: . : WHATS_NEW lib/metadata : metadata.c Log message: Alloc PV internal structure from VG mempool if possible. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1091&r2=1.1092 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.211&r2=1.212 --- LVM2/WHATS_NEW 2009/04/21 14:31:57 1.1091 +++ LVM2/WHATS_NEW 2009/04/22 09:31:30 1.1092 @@ -1,5 +1,6 @@ Version 2.02.46 - ================================ + Alloc PV internal structure from VG mempool if possible. Fix metadata backup to run after vg_commit always. Tidy clvmd volume lock cache functions. Fix pvs report for orphan PVs when segment attributes are requested. --- LVM2/lib/metadata/metadata.c 2009/04/10 10:01:08 1.211 +++ LVM2/lib/metadata/metadata.c 2009/04/22 09:31:31 1.212 @@ -38,6 +38,7 @@ (((const struct physical_volume *)(handle))->field) static struct physical_volume *_pv_read(struct cmd_context *cmd, + struct dm_pool *pvmem, const char *pv_name, struct dm_list *mdas, uint64_t *label_sector, @@ -1070,7 +1071,7 @@ { struct physical_volume *pv; - if (!(pv = _pv_read(cmd, pv_name, NULL, NULL, 1, 0))) { + if (!(pv = _pv_read(cmd, cmd->mem, pv_name, NULL, NULL, 1, 0))) { log_error("Physical volume %s not found", pv_name); return NULL; } @@ -1079,7 +1080,7 @@ /* If a PV has no MDAs - need to search all VGs for it */ if (!scan_vgs_for_pvs(cmd)) return_NULL; - if (!(pv = _pv_read(cmd, pv_name, NULL, NULL, 1, 0))) { + if (!(pv = _pv_read(cmd, cmd->mem, pv_name, NULL, NULL, 1, 0))) { log_error("Physical volume %s not found", pv_name); return NULL; } @@ -1684,7 +1685,7 @@ } dm_list_iterate_items(info, &vginfo->infos) { - if (!(pv = _pv_read(cmd, dev_name(info->dev), NULL, NULL, 1, 0))) { + if (!(pv = _pv_read(cmd, mem, dev_name(info->dev), NULL, NULL, 1, 0))) { continue; } if (!(pvl = dm_pool_zalloc(mem, sizeof(*pvl)))) { @@ -2216,11 +2217,12 @@ struct dm_list *mdas, uint64_t *label_sector, int warnings, int scan_label_only) { - return _pv_read(cmd, pv_name, mdas, label_sector, warnings, scan_label_only); + return _pv_read(cmd, cmd->mem, pv_name, mdas, label_sector, warnings, scan_label_only); } /* FIXME Use label functions instead of PV functions */ static struct physical_volume *_pv_read(struct cmd_context *cmd, + struct dm_pool *pvmem, const char *pv_name, struct dm_list *mdas, uint64_t *label_sector, @@ -2245,7 +2247,7 @@ if (label_sector && *label_sector) *label_sector = label->sector; - if (!(pv = dm_pool_zalloc(cmd->mem, sizeof(*pv)))) { + if (!(pv = dm_pool_zalloc(pvmem, sizeof(*pv)))) { log_error("pv allocation for '%s' failed", pv_name); return NULL; } @@ -2263,8 +2265,8 @@ if (!pv->size) return NULL; - - if (!alloc_pv_segment_whole_pv(cmd->mem, pv)) + + if (!alloc_pv_segment_whole_pv(pvmem, pv)) return_NULL; return pv; @@ -2918,7 +2920,7 @@ pv_t *pv_by_path(struct cmd_context *cmd, const char *pv_name) { struct dm_list mdas; - + dm_list_init(&mdas); - return _pv_read(cmd, pv_name, &mdas, NULL, 1, 0); + return _pv_read(cmd, cmd->mem, pv_name, &mdas, NULL, 1, 0); }
next reply other threads:[~2009-04-22 9:31 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-04-22 9:31 mbroz [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-12 14:18 zkabelac 2012-02-23 0:11 agk 2012-02-13 11:01 zkabelac 2012-02-13 10:58 zkabelac 2012-02-13 10:51 zkabelac 2011-11-18 19:28 zkabelac 2011-10-24 10:24 zkabelac 2011-08-11 16:31 prajnoha 2011-08-04 15:18 zkabelac 2011-03-29 21:57 zkabelac 2011-03-11 15:06 prajnoha 2011-03-10 13:12 zkabelac 2010-12-08 10:45 zkabelac 2010-11-29 11:08 zkabelac 2010-08-19 23:03 mbroz 2010-06-22 21:10 mbroz 2010-05-21 12:45 zkabelac 2010-04-01 11:43 agk 2010-03-02 21:56 snitzer 2010-01-21 21:09 wysochanski 2010-01-05 16:01 mbroz 2009-12-18 12:45 mbroz 2009-12-18 12:44 mbroz 2009-12-11 13:14 zkabelac 2009-12-09 19:29 mbroz 2009-08-20 7:03 mbroz 2009-07-16 3:25 wysochanski 2009-05-27 13:19 agk 2009-05-12 19:09 mbroz 2009-04-10 9:56 mbroz 2009-01-26 22:43 agk 2008-09-25 15:59 mbroz 2008-06-03 17:56 agk 2008-05-08 18:06 agk 2008-04-07 22:12 agk 2008-04-04 15:41 wysochanski 2007-10-12 18:37 wysochanski 2007-07-02 21:48 wysochanski 2006-09-21 20:25 agk 2006-08-09 19:33 agk 2006-07-04 19:36 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090422093133.12921.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).