public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/format_text archiver.c Date: Tue, 19 May 2009 09:45:00 -0000 [thread overview] Message-ID: <20090519094534.28044.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2009-05-19 09:45:34 Modified files: lib/format_text: archiver.c Log message: vgcfgrestore should not quietly fail when backup file has missing PVs. (fixes previous commit: Fix segfault for vgcfgrestore on VG with missing PVs.) Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_text/archiver.c.diff?cvsroot=lvm2&r1=1.24&r2=1.25 --- LVM2/lib/format_text/archiver.c 2009/04/22 09:39:46 1.24 +++ LVM2/lib/format_text/archiver.c 2009/05/19 09:45:33 1.25 @@ -335,7 +335,7 @@ const char *file) { struct volume_group *vg; - int r = 0; + int missing_pvs, r = 0; /* * Read in the volume group from the text file. @@ -343,11 +343,12 @@ if (!(vg = backup_read_vg(cmd, vg_name, file))) return_0; - /* - * If PV is missing, there is already message from read above - */ - if (!vg_missing_pv_count(vg)) + missing_pvs = vg_missing_pv_count(vg); + if (missing_pvs == 0) r = backup_restore_vg(cmd, vg); + else + log_error("Cannot restore Volume Group %s with %i PVs " + "marked as missing.", vg->name, missing_pvs); vg_release(vg); return r;
next reply other threads:[~2009-05-19 9:45 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-05-19 9:45 mbroz [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-01-20 11:01 zkabelac 2011-02-28 20:50 mbroz 2011-01-05 15:06 zkabelac 2010-06-29 15:04 wysochanski 2005-05-24 17:37 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090519094534.28044.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).