public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib Makefile.in Date: Wed, 03 Jun 2009 11:31:00 -0000 [thread overview] Message-ID: <20090603113108.12820.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2009-06-03 11:31:08 Modified files: lib : Makefile.in Log message: Build shared parts with 'make' command (mpatocka) When some parts of lvm are built as shared libraries (for example with --with-snapshots=shared), the 'make' command does not build these parts. The shared parts are built with 'make install' command. This bug can be seen if you go to 'lib' subdirectory and type 'make'. If you type 'make', the shared libraries are not built, if you type 'make all', the shared libraries are built. The reason for the bug is the line $(SUBDIRS): $(LIB_STATIC) If make is executed without any arguments, it makes the first target in the Makefile. If the first target is '$(SUBDIRS): $(LIB_STATIC)', it only builds static libraries. This patch moves '$(SUBDIRS): $(LIB_STATIC)' after include $(top_srcdir)/make.tmpl. make.tmpl contains the 'all' target as its first target, so 'make' will be equivalent to 'make all' and shared libraries will be build with 'make' command. Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/Makefile.in.diff?cvsroot=lvm2&r1=1.91&r2=1.92 --- LVM2/lib/Makefile.in 2009/03/17 13:59:56 1.91 +++ LVM2/lib/Makefile.in 2009/06/03 11:31:06 1.92 @@ -143,12 +143,12 @@ LIB_NAME = liblvm-internal LIB_STATIC = $(LIB_NAME).a -$(SUBDIRS): $(LIB_STATIC) - CLEAN_TARGETS += $(LIB_NAME).cflow include $(top_srcdir)/make.tmpl +$(SUBDIRS): $(LIB_STATIC) + $(LIB_NAME).cflow: $(SOURCES) set -e; (echo -n "SOURCES += "; \ echo $(SOURCES) | \
reply other threads:[~2009-06-03 11:31 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090603113108.12820.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).