public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/commands/toolcontext.c Date: Mon, 15 Jun 2009 11:56:00 -0000 [thread overview] Message-ID: <20090615115640.9629.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2009-06-15 11:56:37 Modified files: . : WHATS_NEW lib/commands : toolcontext.c Log message: Fix memory leaks in toolcontext error path. E.g. # vgscan Parse error at byte 2360 (line 54): expected a value Failed to load config file /etc/lvm/lvm.conf You have a memory leak (not released memory pool): [0x818c788] library (12 bytes) ... Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1147&r2=1.1148 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/commands/toolcontext.c.diff?cvsroot=lvm2&r1=1.74&r2=1.75 --- LVM2/WHATS_NEW 2009/06/12 08:34:15 1.1147 +++ LVM2/WHATS_NEW 2009/06/15 11:56:31 1.1148 @@ -1,5 +1,6 @@ Version 2.02.48 - =============================== + Fix memory leaks in toolcontext error path. Re-instate partial activation support in clustered mode. (2.02.40) Allow metadata correction even when PVs are missing. Use 'lvm lvresize' instead of 'lvresize' in fsadm. --- LVM2/lib/commands/toolcontext.c 2009/04/02 20:46:11 1.74 +++ LVM2/lib/commands/toolcontext.c 2009/06/15 11:56:36 1.75 @@ -516,15 +516,15 @@ { struct config_tree_list *cfl; + dm_list_iterate_items(cfl, &cmd->config_files) { + destroy_config_tree(cfl->cft); + } + if (cmd->cft && cmd->cft->root) { destroy_config_tree(cmd->cft); cmd->cft = NULL; } - dm_list_iterate_items(cfl, &cmd->config_files) { - destroy_config_tree(cfl->cft); - } - dm_list_init(&cmd->config_files); } @@ -1110,6 +1110,14 @@ return cmd; error: + _destroy_tag_configs(cmd); + dev_cache_exit(); + if (cmd->filter) + cmd->filter->destroy(cmd->filter); + if (cmd->mem) + dm_pool_destroy(cmd->mem); + if (cmd->libmem) + dm_pool_destroy(cmd->libmem); dm_free(cmd); return NULL; }
next reply other threads:[~2009-06-15 11:56 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-06-15 11:56 mbroz [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-05-23 13:02 zkabelac 2012-03-23 9:42 zkabelac 2012-02-27 10:05 zkabelac 2012-02-08 10:46 zkabelac 2011-07-08 16:49 agk 2011-06-28 0:23 agk 2010-11-24 9:34 zkabelac 2010-04-30 12:37 zkabelac 2009-07-21 20:00 mpatocka 2009-07-14 12:17 mbroz 2009-04-02 20:46 taka 2007-02-08 17:31 agk 2007-01-23 16:03 agk 2005-01-27 15:50 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090615115640.9629.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).