public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/metadata metadata-exported.h metadata.c Date: Wed, 08 Jul 2009 14:28:00 -0000 [thread overview] Message-ID: <20090708142830.19624.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2009-07-08 14:28:30 Modified files: lib/metadata : metadata-exported.h metadata.c Log message: Remove unneeded LOCK_KEEP from vg_read() interface. Remove unneeded LOCK_KEEP from vg_read() interface. Update comment to clarify cases where _vg_lock_and_read() may return with an error but the lock held. Would be nice to make the vg_read() interface consistent with regards to lock held and error behavior. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata-exported.h.diff?cvsroot=lvm2&r1=1.78&r2=1.79 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.231&r2=1.232 --- LVM2/lib/metadata/metadata-exported.h 2009/07/01 17:00:50 1.78 +++ LVM2/lib/metadata/metadata-exported.h 2009/07/08 14:28:30 1.79 @@ -113,7 +113,6 @@ /* FIXME Deduce these next requirements internally instead of having caller specify. */ #define LOCK_NONBLOCKING 0x00000100U /* Fail if not available immediately. */ -#define LOCK_KEEP 0x00000200U /* Do not unlock upon read failure. */ /* A meta-flag, useful with toollib for_each_* functions. */ #define READ_FOR_UPDATE 0x00100000U --- LVM2/lib/metadata/metadata.c 2009/07/06 19:04:25 1.231 +++ LVM2/lib/metadata/metadata.c 2009/07/08 14:28:30 1.232 @@ -2793,7 +2793,6 @@ goto_bad; } } - failure |= _vg_bad_status_bits(vg, status_flags); if (failure) @@ -2803,7 +2802,7 @@ bad: if (failure != (FAILED_NOTFOUND | READ_CHECK_EXISTENCE) && - !(misc_flags & LOCK_KEEP) && !already_locked) + !already_locked) unlock_vg(cmd, lock_name); return _vg_make_handle(cmd, vg, failure); @@ -2821,7 +2820,11 @@ * FAILED_RESIZEABLE * - locking failed: FAILED_LOCKING * - * On failures, all locks are released, unless LOCK_KEEP has been supplied. + * On failures, all locks are released, unless one of the following applies: + * - failure == (FAILED_NOTFOUND | READ_CHECK_EXISTENCE) + * - vgname_is_locked(lock_name) is true + * FIXME: remove the above 2 conditions if possible and make an error always + * release the lock. * * Volume groups are opened read-only unless flags contains READ_FOR_UPDATE. *
next reply other threads:[~2009-07-08 14:28 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-07-08 14:28 wysochanski [this message] -- strict thread matches above, loose matches on Subject: below -- 2010-06-29 22:41 wysochanski 2010-06-28 20:36 wysochanski 2010-05-19 11:52 wysochanski 2010-04-13 17:26 wysochanski 2009-07-26 2:02 wysochanski 2009-07-26 1:53 wysochanski 2009-07-15 17:26 agk 2009-07-15 6:10 mornfall 2009-07-10 21:19 wysochanski 2009-07-08 14:31 wysochanski 2009-06-09 14:29 wysochanski 2009-01-27 1:48 agk 2009-01-27 0:40 agk 2009-01-26 22:13 agk 2008-03-13 22:51 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090708142830.19624.qmail@sourceware.org \ --to=wysochanski@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).