From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2071 invoked by alias); 14 Jul 2009 02:14:07 -0000 Received: (qmail 1909 invoked by uid 9657); 14 Jul 2009 02:14:06 -0000 Date: Tue, 14 Jul 2009 02:14:00 -0000 Message-ID: <20090714021406.1906.qmail@sourceware.org> From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 lib/metadata/metadata.c tools/vgextend.c Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00062.txt.bz2 CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2009-07-14 02:14:05 Modified files: lib/metadata : metadata.c tools : vgextend.c Log message: Remove READ_REQUIRE_RESIZEABLE from vgextend by moving check inside vg_extend. Move the check for the RESIZEABLE flag inside the vg_extend function. When we consolidated the vg locking, reading, and status flag checking, we tied the check for the RESIZEABLE flag to the vg_read() call. The problem with this is you cannot know what other APIs the application my or may not call after a vg_read() call. Thus the READ_REQUIRE_RESIZEABLE flag is not really ideal - ideally we should be checking for this flag on a specific operation, not inside the vg_read() call. This patch moves one check inside the library. Signed-off-by: Dave Wysochanski Acked-by: Alasdair G Kergon Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.246&r2=1.247 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgextend.c.diff?cvsroot=lvm2&r1=1.46&r2=1.47 --- LVM2/lib/metadata/metadata.c 2009/07/10 21:19:37 1.246 +++ LVM2/lib/metadata/metadata.c 2009/07/14 02:14:04 1.247 @@ -439,6 +439,9 @@ struct physical_volume *pv; struct cmd_context *cmd = vg->cmd; + if (_vg_bad_status_bits(vg, RESIZEABLE_VG)) + return 0; + if (!lock_vol(cmd, VG_ORPHANS, LCK_VG_WRITE)) { log_error("Can't get lock for orphan PVs"); return 0; --- LVM2/tools/vgextend.c 2009/07/10 20:09:21 1.46 +++ LVM2/tools/vgextend.c 2009/07/14 02:14:05 1.47 @@ -37,8 +37,7 @@ argv++; log_verbose("Checking for volume group \"%s\"", vg_name); - vg = vg_read_for_update(cmd, vg_name, NULL, - READ_REQUIRE_RESIZEABLE); + vg = vg_read_for_update(cmd, vg_name, NULL, 0); if (vg_read_error(vg)) { vg_release(vg); return ECMD_FAILED;