From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-2067-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 20573 invoked by alias); 15 Jul 2009 03:30:06 -0000
Received: (qmail 20557 invoked by uid 9657); 15 Jul 2009 03:30:05 -0000
Date: Wed, 15 Jul 2009 03:30:00 -0000
Message-ID: <20090715033005.20555.qmail@sourceware.org>
From: wysochanski@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/tools vgcfgbackup.c
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2009-07/txt/msg00076.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	wysochanski@sourceware.org	2009-07-15 03:30:04

Modified files:
	tools          : vgcfgbackup.c 

Log message:
	Fix FAILED_INCONSISTENT case in vg_backup_single - typeo on 'if' condition.
	
	In vg_backup_single, we should error out if we vg_read_error(vg) and the
	error code we received was anything other than FAILED_INCONSISTENT.
	Original code contained an error because C operator precedence.
	Note - this was part of the vg_read() so no WHATS_NEW entry neceesary.
	
	Author: Dave Wysochanski <dwysocha@redhat.com>

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgcfgbackup.c.diff?cvsroot=lvm2&r1=1.28&r2=1.29

--- LVM2/tools/vgcfgbackup.c	2009/07/01 17:00:52	1.28
+++ LVM2/tools/vgcfgbackup.c	2009/07/15 03:30:04	1.29
@@ -54,7 +54,7 @@
 	char **last_filename = (char **)handle;
 	char *filename;
 
-	if (vg_read_error(vg) && !vg_read_error(vg) == FAILED_INCONSISTENT)
+	if (vg_read_error(vg) && (vg_read_error(vg) != FAILED_INCONSISTENT))
 		return ECMD_FAILED;
 
 	if (arg_count(cmd, file_ARG)) {