public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools toollib.c Date: Wed, 15 Jul 2009 05:23:00 -0000 [thread overview] Message-ID: <20090715052320.26833.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2009-07-15 05:23:20 Modified files: tools : toollib.c Log message: Check for certain vg_read errors in _process_one_vg iterator. In _process_one_vg, we should never proceed if the VG read fails with certain conditions. If we cannot allocate or construct the volume_group structure, we should not proceed - this is true regardless of the tool calling the iterator. In other cases, when the volume group structure is constructed but there is some error (PVs missing, metadata corrupted, etc), some tools may want to process the VG while others may not. Author: Dave Wysochanski <dwysocha@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/toollib.c.diff?cvsroot=lvm2&r1=1.160&r2=1.161 --- LVM2/tools/toollib.c 2009/07/07 01:18:35 1.160 +++ LVM2/tools/toollib.c 2009/07/15 05:23:19 1.161 @@ -431,6 +431,9 @@ log_verbose("Finding volume group \"%s\"", vg_name); vg = vg_read(cmd, vg_name, vgid, flags); + if (vg_read_error(vg) == FAILED_ALLOCATION || + vg_read_error(vg) == FAILED_NOTFOUND) + return ECMD_FAILED; if (!dm_list_empty(tags)) { /* Only process if a tag matches or it's on arg_vgnames */
next reply other threads:[~2009-07-15 5:23 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-07-15 5:23 wysochanski [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-04 15:58 zkabelac 2010-12-20 14:05 zkabelac 2010-12-01 12:22 zkabelac 2010-12-01 10:36 zkabelac 2010-10-25 12:08 zkabelac 2010-04-28 12:23 zkabelac 2009-07-15 12:23 wysochanski 2009-07-15 12:15 wysochanski 2009-06-10 11:15 mbroz 2009-06-10 10:15 mbroz 2009-04-23 16:45 mornfall 2009-04-07 10:22 mbroz 2008-06-11 15:02 meyering 2007-11-12 14:36 agk 2006-11-03 21:23 agk 2006-03-10 15:41 agk 2005-01-19 17:31 agk 2005-01-19 17:31 agk 2004-06-20 15:14 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090715052320.26833.qmail@sourceware.org \ --to=wysochanski@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).