From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-2076-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 17188 invoked by alias); 15 Jul 2009 12:15:37 -0000
Received: (qmail 17172 invoked by uid 9657); 15 Jul 2009 12:15:36 -0000
Date: Wed, 15 Jul 2009 12:15:00 -0000
Message-ID: <20090715121536.17170.qmail@sourceware.org>
From: wysochanski@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/tools toollib.c
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2009-07/txt/msg00085.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	wysochanski@sourceware.org	2009-07-15 12:15:36

Modified files:
	tools          : toollib.c 

Log message:
	Fix memory leak in _process_one_vg error path.
	
	Author: Dave Wysochanski <dwysocha@redhat.com>

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/toollib.c.diff?cvsroot=lvm2&r1=1.162&r2=1.163

--- LVM2/tools/toollib.c	2009/07/15 05:50:22	1.162
+++ LVM2/tools/toollib.c	2009/07/15 12:15:36	1.163
@@ -432,8 +432,10 @@
 
 	vg = vg_read(cmd, vg_name, vgid, flags);
 	if (vg_read_error(vg) == FAILED_ALLOCATION ||
-	    vg_read_error(vg) == FAILED_NOTFOUND)
+	    vg_read_error(vg) == FAILED_NOTFOUND) {
+		vg_release(vg);
 		return ECMD_FAILED;
+	}
 
 	if (!dm_list_empty(tags)) {
 		/* Only process if a tag matches or it's on arg_vgnames */