public inbox for
help / color / mirror / Atom feed
Subject: LVM2/lib/device dev-md.c
Date: Mon, 20 Jul 2009 18:33:00 -0000	[thread overview]
Message-ID: <> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	2009-07-20 18:33:16

Modified files:
	lib/device     : dev-md.c 

Log message:
	Cast MAJOR() and MINOR() to int when used with "%d" in dm_snprintf() call.
	Fixes SEGV in _md_sysfs_attribute_snprintf() on 32-bit systems.


--- LVM2/lib/device/dev-md.c	2009/07/06 19:04:25	1.14
+++ LVM2/lib/device/dev-md.c	2009/07/20 18:33:16	1.15
@@ -139,8 +139,8 @@
 	if (!sysfs_dir || !*sysfs_dir)
 		return ret;
-	ret = dm_snprintf(path, size, "%s/dev/block/%d:%d/md/%s",
-	      sysfs_dir, MAJOR(dev->dev), MINOR(dev->dev), attribute);
+	ret = dm_snprintf(path, size, "%s/dev/block/%d:%d/md/%s", sysfs_dir,
+			  (int)MAJOR(dev->dev), (int)MINOR(dev->dev), attribute);
 	if (ret < 0) {
 		log_error("dm_snprintf md %s failed", attribute);
 		return ret;

             reply	other threads:[~2009-07-20 18:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-20 18:33 snitzer [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-07-20 18:44 snitzer
2008-09-19  7:18 agk
2007-10-24 11:24 agk
2007-10-24  0:30 agk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).