public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: mpatocka@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW lib/commands/toolcontext.c
Date: Tue, 21 Jul 2009 20:00:00 -0000	[thread overview]
Message-ID: <20090721200005.10457.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	mpatocka@sourceware.org	2009-07-21 20:00:04

Modified files:
	.              : WHATS_NEW 
	lib/commands   : toolcontext.c 

Log message:
	Pass struct cmd_context as a first argument to init_multiple_segtypes.
	
	Remove redundant assignment seglib.cmd = cmd (done already at the beginning
	of the function).
	
	Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1194&r2=1.1195
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/commands/toolcontext.c.diff?cvsroot=lvm2&r1=1.82&r2=1.83

--- LVM2/WHATS_NEW	2009/07/21 11:10:49	1.1194
+++ LVM2/WHATS_NEW	2009/07/21 20:00:02	1.1195
@@ -1,5 +1,6 @@
 Version 2.02.50 - 
 ================================
+  Pass a pointer to struct cmd_context to init_multiple_segtypes
   Return EINVALID_CMD_LINE not success when invalid VG name format is used.
   Remove unnecessary messages after vgcreate/vgsplit refactor (2.02.49).
   Add log_errno to set a specific errno and replace log_error in due course.
--- LVM2/lib/commands/toolcontext.c	2009/07/16 00:36:59	1.82
+++ LVM2/lib/commands/toolcontext.c	2009/07/21 20:00:04	1.83
@@ -835,7 +835,8 @@
 	return 1;
 }
 
-static int _init_single_segtype(struct segtype_library *seglib)
+static int _init_single_segtype(struct cmd_context *cmd,
+				struct segtype_library *seglib)
 {
 	struct segment_type *(*init_segtype_fn) (struct cmd_context *);
 	struct segment_type *segtype;
@@ -901,9 +902,8 @@
 	    (cn = find_config_tree_node(cmd, "global/segment_libraries"))) {
 
 		struct config_value *cv;
-		int (*init_multiple_segtypes_fn) (struct segtype_library *);
-
-		seglib.cmd = cmd;
+		int (*init_multiple_segtypes_fn) (struct cmd_context *,
+						  struct segtype_library *);
 
 		for (cv = cn->v; cv; cv = cv->next) {
 			if (cv->type != CFG_STRING) {
@@ -928,7 +928,7 @@
 				init_multiple_segtypes_fn =
 				    _init_single_segtype;
  
-			if (!init_multiple_segtypes_fn(&seglib)) {
+			if (!init_multiple_segtypes_fn(cmd, &seglib)) {
 				struct dm_list *sgtl, *tmp;
 				log_error("init_multiple_segtypes() failed: "
 					  "Unloading shared library %s",


             reply	other threads:[~2009-07-21 20:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-21 20:00 mpatocka [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-05-23 13:02 zkabelac
2012-03-23  9:42 zkabelac
2012-02-27 10:05 zkabelac
2012-02-08 10:46 zkabelac
2011-07-08 16:49 agk
2011-06-28  0:23 agk
2010-11-24  9:34 zkabelac
2010-04-30 12:37 zkabelac
2009-07-14 12:17 mbroz
2009-06-15 11:56 mbroz
2009-04-02 20:46 taka
2007-02-08 17:31 agk
2007-01-23 16:03 agk
2005-01-27 15:50 agk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090721200005.10457.qmail@sourceware.org \
    --to=mpatocka@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).