public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/liblvm lvm_vg.c Date: Fri, 24 Jul 2009 15:12:00 -0000 [thread overview] Message-ID: <20090724151250.17299.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2009-07-24 15:12:50 Modified files: liblvm : lvm_vg.c Log message: Update lvm_vg_extend() to obtain VG_ORPHAN. vg_extend() no longer obtains VG_OPHAN so we must do so in liblvm function. We still have the race in liblvm but we will address this problem later. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/liblvm/lvm_vg.c.diff?cvsroot=lvm2&r1=1.8&r2=1.9 --- LVM2/liblvm/lvm_vg.c 2009/07/24 12:48:21 1.8 +++ LVM2/liblvm/lvm_vg.c 2009/07/24 15:12:50 1.9 @@ -40,11 +40,23 @@ int lvm_vg_extend(vg_t *vg, const char *device) { if (vg_read_error(vg)) - goto_bad; + return 0; - return vg_extend(vg, 1, (char **) &device); -bad: - return 0; + if (!lock_vol(vg->cmd, VG_ORPHANS, LCK_VG_WRITE)) { + log_error("Can't get lock for orphan PVs"); + return 0; + } + + if (!vg_extend(vg, 1, (char **) &device)) { + unlock_vg(vg->cmd, VG_ORPHANS); + return 0; + } + /* + * FIXME: Either commit to disk, or keep holding VG_ORPHANS and + * release in lvm_vg_close(). + */ + unlock_vg(vg->cmd, VG_ORPHANS); + return 1; } int lvm_vg_set_extent_size(vg_t *vg, uint32_t new_size)
next reply other threads:[~2009-07-24 15:12 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-07-24 15:12 wysochanski [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-04-01 13:44 prajnoha 2009-07-26 20:29 wysochanski 2009-07-22 3:13 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090724151250.17299.qmail@sourceware.org \ --to=wysochanski@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).