public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: wysochanski@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/tools lvcreate.c
Date: Sun, 26 Jul 2009 02:32:00 -0000 [thread overview]
Message-ID: <20090726023227.16225.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: wysochanski@sourceware.org 2009-07-26 02:32:27
Modified files:
tools : lvcreate.c
Log message:
Comment lvcreate_params struct.
Author: Dave Wysochanski <dwysocha@redhat.com>
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?cvsroot=lvm2&r1=1.203&r2=1.204
--- LVM2/tools/lvcreate.c 2009/07/26 02:32:00 1.203
+++ LVM2/tools/lvcreate.c 2009/07/26 02:32:26 1.204
@@ -26,39 +26,39 @@
/* FIXME: refactor and reduce the size of this struct! */
struct lvcreate_params {
/* flags */
- int snapshot;
- int zero;
- int major;
- int minor;
- int corelog;
- int nosync;
+ int snapshot; /* snap */
+ int zero; /* all */
+ int major; /* all */
+ int minor; /* all */
+ int corelog; /* mirror */
+ int nosync; /* mirror */
+
+ char *origin; /* snap */
+ const char *vg_name; /* all */
+ const char *lv_name; /* all */
+
+ uint32_t stripes; /* striped */
+ uint32_t stripe_size; /* striped */
+ uint32_t chunk_size; /* snapshot */
+ uint32_t region_size; /* mirror */
- char *origin;
- const char *vg_name;
- const char *lv_name;
-
- uint32_t stripes;
- uint32_t stripe_size;
- uint32_t chunk_size;
- uint32_t region_size;
+ uint32_t mirrors; /* mirror */
- uint32_t mirrors;
-
- const struct segment_type *segtype;
+ const struct segment_type *segtype; /* all */
/* size */
- uint32_t extents;
- uint32_t voriginextents;
- uint64_t voriginsize;
- struct dm_list *pvh;
-
- uint32_t permission;
- uint32_t read_ahead;
- alloc_policy_t alloc;
-
- int pv_count;
- char **pvs;
- const char *tag;
+ uint32_t extents; /* all */
+ uint32_t voriginextents; /* snapshot */
+ uint64_t voriginsize; /* snapshot */
+ struct dm_list *pvh; /* all */
+
+ uint32_t permission; /* all */
+ uint32_t read_ahead; /* all */
+ alloc_policy_t alloc; /* all */
+
+ int pv_count; /* all; redundant? */
+ char **pvs; /* all; redundant? */
+ const char *tag; /* all */
};
static uint64_t _extents_from_size(struct cmd_context *cmd, uint64_t size,
next reply other threads:[~2009-07-26 2:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-26 2:32 wysochanski [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-02 20:18 zkabelac
2012-02-01 1:54 agk
2011-11-10 12:40 zkabelac
2011-11-10 12:39 zkabelac
2011-09-27 12:37 agk
2011-09-07 9:25 zkabelac
2011-09-06 15:35 agk
2011-03-25 21:56 jbrassow
2010-10-25 12:05 zkabelac
2010-05-11 21:40 jbrassow
2009-07-26 2:32 wysochanski
2009-07-26 2:32 wysochanski
2009-07-26 2:31 wysochanski
2009-07-26 2:31 wysochanski
2009-07-26 2:30 wysochanski
2009-06-06 22:06 mbroz
2009-05-27 13:07 agk
2009-04-26 8:12 prajnoha
2008-07-17 15:19 wysochanski
2008-01-16 15:26 agk
2007-10-01 15:01 wysochanski
2007-09-24 13:29 wysochanski
2006-10-16 16:47 agk
2005-11-12 22:00 agk
2005-10-28 14:38 agk
2005-09-30 22:20 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090726023227.16225.qmail@sourceware.org \
--to=wysochanski@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).