public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools lvcreate.c Date: Sun, 26 Jul 2009 02:32:00 -0000 [thread overview] Message-ID: <20090726023250.16555.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2009-07-26 02:32:50 Modified files: tools : lvcreate.c Log message: Move pvs and pv_count fields from lvcreate_params to lvcreate_cmdline_params. No functional change. Author: Dave Wysochanski <dwysocha@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?cvsroot=lvm2&r1=1.204&r2=1.205 --- LVM2/tools/lvcreate.c 2009/07/26 02:32:26 1.204 +++ LVM2/tools/lvcreate.c 2009/07/26 02:32:50 1.205 @@ -21,6 +21,8 @@ struct lvcreate_cmdline_params { percent_t percent; uint64_t size; + char **pvs; + int pv_count; }; /* FIXME: refactor and reduce the size of this struct! */ @@ -56,8 +58,6 @@ uint32_t read_ahead; /* all */ alloc_policy_t alloc; /* all */ - int pv_count; /* all; redundant? */ - char **pvs; /* all; redundant? */ const char *tag; /* all */ }; @@ -185,9 +185,9 @@ * Create the pv list before we parse lcp->percent - might be * PERCENT_PVSs */ - if (lp->pv_count) { + if (lcp->pv_count) { if (!(lp->pvh = create_pv_list(vg->cmd->mem, vg, - lp->pv_count, lp->pvs, 1))) + lcp->pv_count, lcp->pvs, 1))) return_0; } else lp->pvh = &vg->pvs; @@ -200,7 +200,7 @@ lp->extents = lp->extents * vg->free_count / 100; break; case PERCENT_PVS: - if (!lp->pv_count) { + if (!lcp->pv_count) { log_error("Please specify physical volume(s) " "with %%PVS"); return 0; @@ -603,8 +603,8 @@ return 0; } - lp->pv_count = argc; - lp->pvs = argv; + lcp->pv_count = argc; + lcp->pvs = argv; return 1; }
next reply other threads:[~2009-07-26 2:32 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-07-26 2:32 wysochanski [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-02 20:18 zkabelac 2012-02-01 1:54 agk 2011-11-10 12:40 zkabelac 2011-11-10 12:39 zkabelac 2011-09-27 12:37 agk 2011-09-07 9:25 zkabelac 2011-09-06 15:35 agk 2011-03-25 21:56 jbrassow 2010-10-25 12:05 zkabelac 2010-05-11 21:40 jbrassow 2009-07-26 2:32 wysochanski 2009-07-26 2:32 wysochanski 2009-07-26 2:31 wysochanski 2009-07-26 2:31 wysochanski 2009-07-26 2:30 wysochanski 2009-06-06 22:06 mbroz 2009-05-27 13:07 agk 2009-04-26 8:12 prajnoha 2008-07-17 15:19 wysochanski 2008-01-16 15:26 agk 2007-10-01 15:01 wysochanski 2007-09-24 13:29 wysochanski 2006-10-16 16:47 agk 2005-11-12 22:00 agk 2005-10-28 14:38 agk 2005-09-30 22:20 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090726023250.16555.qmail@sourceware.org \ --to=wysochanski@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).