public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: ccaulfield@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW daemons/clvmd/lvm-functions.c Date: Wed, 05 Aug 2009 14:18:00 -0000 [thread overview] Message-ID: <20090805141836.17430.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: ccaulfield@sourceware.org 2009-08-05 14:18:36 Modified files: . : WHATS_NEW daemons/clvmd : lvm-functions.c Log message: Fix locking in clvmd The changes to remove LCK_NONBLOCK from the LVM locks broke clvmd because the code was clearly wrong but working anyway! The constant was being masked rather than the variable that was supposed to match against it. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1231&r2=1.1232 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/lvm-functions.c.diff?cvsroot=lvm2&r1=1.67&r2=1.68 --- LVM2/WHATS_NEW 2009/08/04 15:55:43 1.1231 +++ LVM2/WHATS_NEW 2009/08/05 14:18:35 1.1232 @@ -1,5 +1,6 @@ Version 2.02.51 - ================================ + Fix locking in clvmd (2.02.50). Add --noudevsync option for relevant LVM tools. Add activation/udev_sync to lvm.conf. Only change LV symlinks on ACTIVATE not PRELOAD. --- LVM2/daemons/clvmd/lvm-functions.c 2009/07/24 18:15:07 1.67 +++ LVM2/daemons/clvmd/lvm-functions.c 2009/08/05 14:18:35 1.68 @@ -479,29 +479,29 @@ cmd->partial_activation = (lock_flags & LCK_PARTIAL_MODE) ? 1 : 0; - switch (command) { - case LCK_LV_EXCLUSIVE & LCK_MASK: + switch (command & LCK_MASK) { + case LCK_LV_EXCLUSIVE: status = do_activate_lv(resource, lock_flags, LKM_EXMODE); break; - case LCK_LV_SUSPEND & LCK_MASK: + case LCK_LV_SUSPEND: status = do_suspend_lv(resource); if (!status) suspended++; break; case LCK_UNLOCK: - case LCK_LV_RESUME & LCK_MASK: /* if active */ + case LCK_LV_RESUME: /* if active */ status = do_resume_lv(resource); if (!status) suspended--; break; - case LCK_LV_ACTIVATE & LCK_MASK: + case LCK_LV_ACTIVATE: status = do_activate_lv(resource, lock_flags, LKM_CRMODE); break; - case LCK_LV_DEACTIVATE & LCK_MASK: + case LCK_LV_DEACTIVATE: status = do_deactivate_lv(resource, lock_flags); break;
next reply other threads:[~2009-08-05 14:18 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-08-05 14:18 ccaulfield [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-01 9:54 zkabelac 2012-02-23 22:50 zkabelac 2011-08-10 11:00 mbroz 2011-03-02 23:38 mbroz 2010-07-01 21:23 mbroz 2010-03-24 22:25 snitzer 2010-01-26 8:00 mbroz 2009-12-09 19:01 mbroz 2009-12-09 19:00 mbroz 2009-12-09 18:55 mbroz 2009-12-09 18:45 mbroz 2009-10-22 17:45 agk 2009-10-01 14:14 ccaulfield 2009-03-05 16:25 mbroz 2008-04-08 13:03 ccaulfield 2008-04-04 8:53 ccaulfield 2007-08-24 8:29 pcaulfield 2007-08-23 12:19 pcaulfield 2007-04-24 15:13 pcaulfield 2005-02-14 9:07 pcaulfield 2005-02-02 11:42 pcaulfield 2004-10-04 9:23 pcaulfield
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090805141836.17430.qmail@sourceware.org \ --to=ccaulfield@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).