public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/activate/activate.c Date: Tue, 29 Sep 2009 15:17:00 -0000 [thread overview] Message-ID: <20090929151754.19072.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2009-09-29 15:17:54 Modified files: . : WHATS_NEW lib/activate : activate.c Log message: Return fail if lv_deactivate did not removed device from kernel. lv_deactivate now returns always success, because tree deactivation functions (see dm_tree_deactivate_children) always returns success. Because code should return failure in lv_deactivate at least, fix it by checking for device existence after real deactivation call. (After discussion this was prefered solution to dm tree function rewrite which affects snapshots and mirrors.) Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1277&r2=1.1278 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/activate.c.diff?cvsroot=lvm2&r1=1.153&r2=1.154 --- LVM2/WHATS_NEW 2009/09/28 21:23:02 1.1277 +++ LVM2/WHATS_NEW 2009/09/29 15:17:54 1.1278 @@ -1,5 +1,6 @@ Version 2.02.54 - ===================================== + Return fail if lv_deactivate fails to remove device from kernel. Provide alternative implementation of obsolete siginterrupt(). Consolidate LV allocation into alloc_lv(). Treat input units of both 's' and 'S' as 512-byte sectors. (2.02.49) --- LVM2/lib/activate/activate.c 2009/06/01 12:43:32 1.153 +++ LVM2/lib/activate/activate.c 2009/09/29 15:17:54 1.154 @@ -1017,6 +1017,8 @@ memlock_dec(); fs_unlock(); + if (!lv_info(cmd, lv, &info, 1, 0) || info.exists) + r = 0; out: if (lv) vg_release(lv->vg);
next reply other threads:[~2009-09-29 15:17 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-09-29 15:17 mbroz [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-01-25 22:16 zkabelac 2011-02-18 14:26 zkabelac 2010-08-16 23:29 agk 2010-07-12 11:37 prajnoha 2010-05-21 14:34 zkabelac 2010-01-27 13:24 mbroz 2009-12-03 19:23 mbroz 2009-12-01 19:10 mbroz 2009-10-30 13:07 agk 2009-09-29 18:50 agk 2007-08-01 20:29 jbrassow 2006-12-20 16:19 agk 2005-12-22 16:13 agk 2004-05-11 17:09 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090929151754.19072.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).