From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9292 invoked by alias); 22 Oct 2009 17:33:10 -0000 Received: (qmail 9277 invoked by uid 9447); 22 Oct 2009 17:33:10 -0000 Date: Thu, 22 Oct 2009 17:33:00 -0000 Message-ID: <20091022173310.9275.qmail@sourceware.org> From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/cache/lvmcache.c Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00044.txt.bz2 CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2009-10-22 17:33:09 Modified files: . : WHATS_NEW lib/cache : lvmcache.c Log message: Remember to clear 'global lock held during cache refresh' state after use. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1299&r2=1.1300 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/cache/lvmcache.c.diff?cvsroot=lvm2&r1=1.69&r2=1.70 --- LVM2/WHATS_NEW 2009/10/22 13:00:07 1.1299 +++ LVM2/WHATS_NEW 2009/10/22 17:33:09 1.1300 @@ -1,5 +1,6 @@ Version 2.02.54 - ===================================== + Remember to clear 'global lock held during cache refresh' state after use. Use udev flags support in LVM. Delay announcing mirror monitoring to syslog until initialisation succeeded. Handle metadata with unknown segment types more gracefully. --- LVM2/lib/cache/lvmcache.c 2009/09/15 13:49:11 1.69 +++ LVM2/lib/cache/lvmcache.c 2009/10/22 17:33:09 1.70 @@ -52,8 +52,15 @@ if (!(_lock_hash = dm_hash_create(128))) return 0; - if (_vg_global_lock_held) + /* + * Reinitialising the cache clears the internal record of + * which locks are held. The global lock can be held during + * this operation so its state must be restored afterwards. + */ + if (_vg_global_lock_held) { lvmcache_lock_vgname(VG_GLOBAL, 0); + _vg_global_lock_held = 0; + } return 1; }