public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mornfall@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/log log.c Date: Tue, 01 Dec 2009 13:54:00 -0000 [thread overview] Message-ID: <20091201135428.24475.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mornfall@sourceware.org 2009-12-01 13:54:28 Modified files: lib/log : log.c Log message: If aborting due to an internal error, always print the message causing this. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/log/log.c.diff?cvsroot=lvm2&r1=1.53&r2=1.54 --- LVM2/lib/log/log.c 2009/11/30 17:17:12 1.53 +++ LVM2/lib/log/log.c 2009/12/01 13:54:27 1.54 @@ -183,7 +183,8 @@ level &= ~_LOG_STDERR; - if (!strncmp(format, "Internal error:", + if (_abort_on_internal_errors && + !strncmp(format, "Internal error:", strlen("Internal error:"))) internal_error = 1; @@ -244,7 +245,7 @@ if (!strcmp("<backtrace>", format) && verbose_level() <= _LOG_DEBUG) break; - if (verbose_level() >= _LOG_DEBUG) { + if (internal_error || verbose_level() >= _LOG_DEBUG) { fprintf(stderr, "%s%s%s", locn, log_command_name(), _msg_prefix); if (_indent) @@ -255,7 +256,7 @@ break; case _LOG_INFO: - if (verbose_level() >= _LOG_INFO) { + if (internal_error || verbose_level() >= _LOG_INFO) { fprintf(stderr, "%s%s%s", locn, log_command_name(), _msg_prefix); if (_indent) @@ -265,7 +266,7 @@ } break; case _LOG_NOTICE: - if (verbose_level() >= _LOG_NOTICE) { + if (internal_error || verbose_level() >= _LOG_NOTICE) { fprintf(stderr, "%s%s%s", locn, log_command_name(), _msg_prefix); if (_indent) @@ -275,7 +276,7 @@ } break; case _LOG_WARN: - if (verbose_level() >= _LOG_WARN) { + if (internal_error || verbose_level() >= _LOG_WARN) { fprintf(use_stderr ? stderr : stdout, "%s%s", log_command_name(), _msg_prefix); vfprintf(use_stderr ? stderr : stdout, trformat, ap); @@ -283,7 +284,7 @@ } break; case _LOG_ERR: - if (verbose_level() >= _LOG_ERR) { + if (internal_error || verbose_level() >= _LOG_ERR) { fprintf(stderr, "%s%s%s", locn, log_command_name(), _msg_prefix); vfprintf(stderr, trformat, ap); @@ -292,7 +293,7 @@ break; case _LOG_FATAL: default: - if (verbose_level() >= _LOG_FATAL) { + if (internal_error || verbose_level() >= _LOG_FATAL) { fprintf(stderr, "%s%s%s", locn, log_command_name(), _msg_prefix); vfprintf(stderr, trformat, ap); @@ -303,7 +304,7 @@ va_end(ap); } - if (internal_error && _abort_on_internal_errors) + if (internal_error) abort(); if (level > debug_level())
next reply other threads:[~2009-12-01 13:54 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-12-01 13:54 mornfall [this message] 2010-01-11 20:30 agk 2010-01-11 20:41 agk 2010-03-23 18:18 mornfall 2010-10-26 8:53 zkabelac 2011-03-30 12:53 zkabelac 2011-08-11 19:21 zkabelac 2012-02-27 11:31 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20091201135428.24475.qmail@sourceware.org \ --to=mornfall@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).