public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/vgcreate.c Date: Thu, 03 Dec 2009 19:20:00 -0000 [thread overview] Message-ID: <20091203192049.26423.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2009-12-03 19:20:49 Modified files: . : WHATS_NEW tools : vgcreate.c Log message: Print error if VG already exist. This test have to be moved because of new vg read error handling. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1338&r2=1.1339 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgcreate.c.diff?cvsroot=lvm2&r1=1.75&r2=1.76 --- LVM2/WHATS_NEW 2009/12/03 19:18:33 1.1338 +++ LVM2/WHATS_NEW 2009/12/03 19:20:48 1.1339 @@ -1,5 +1,6 @@ Version 2.02.57 - ==================================== + Fix error message if VG already exist in vgcreate. Fix tools to use log_error when stopped by user. Fix lvcreate --readahead. Fix clvmd memory leak in lv_info_by_lvid. --- LVM2/tools/vgcreate.c 2009/11/01 20:05:17 1.75 +++ LVM2/tools/vgcreate.c 2009/12/03 19:20:49 1.76 @@ -55,8 +55,13 @@ /* Create the new VG */ vg = vg_create(cmd, vp_new.vg_name); - if (vg_read_error(vg)) - goto_bad; + if (vg_read_error(vg)) { + if (vg_read_error(vg) == FAILED_EXIST) + log_error("A volume group called %s already exists.", vp_new.vg_name); + else + log_error("Can't get lock for %s.", vp_new.vg_name); + goto bad; + } if (!vg_set_extent_size(vg, vp_new.extent_size) || !vg_set_max_lv(vg, vp_new.max_lv) ||
next reply other threads:[~2009-12-03 19:20 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-12-03 19:20 mbroz [this message] -- strict thread matches above, loose matches on Subject: below -- 2008-12-01 20:14 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20091203192049.26423.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).