public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: prajnoha@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools pvmove.c Date: Fri, 04 Dec 2009 14:03:00 -0000 [thread overview] Message-ID: <20091204140318.17556.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: prajnoha@sourceware.org 2009-12-04 14:03:18 Modified files: tools : pvmove.c Log message: Give better message for pvmove when all data on source PV is skipped. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvmove.c.diff?cvsroot=lvm2&r1=1.69&r2=1.70 --- LVM2/tools/pvmove.c 2009/12/03 19:22:24 1.69 +++ LVM2/tools/pvmove.c 2009/12/04 14:03:18 1.70 @@ -180,6 +180,7 @@ struct lv_list *lvl; uint32_t log_count = 0; int lv_found = 0; + int lv_skipped = 0; /* FIXME Cope with non-contiguous => splitting existing segments */ if (!(lv_mirr = lv_create_empty("pvmove%d", NULL, @@ -209,22 +210,27 @@ lv_found = 1; } if (lv_is_origin(lv) || lv_is_cow(lv)) { + lv_skipped = 1; log_print("Skipping snapshot-related LV %s", lv->name); continue; } if (lv->status & MIRRORED) { + lv_skipped = 1; log_print("Skipping mirror LV %s", lv->name); continue; } if (lv->status & MIRROR_LOG) { + lv_skipped = 1; log_print("Skipping mirror log LV %s", lv->name); continue; } if (lv->status & MIRROR_IMAGE) { + lv_skipped = 1; log_print("Skipping mirror image LV %s", lv->name); continue; } if (lv->status & LOCKED) { + lv_skipped = 1; log_print("Skipping locked LV %s", lv->name); continue; } @@ -240,6 +246,10 @@ /* Is temporary mirror empty? */ if (!lv_mirr->le_count) { + if (lv_skipped) + log_error("All data on source PV skipped. " + "It contains locked, hidden or " + "non-top level LVs only."); log_error("No data to move for %s", vg->name); return NULL; }
next reply other threads:[~2009-12-04 14:03 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-12-04 14:03 prajnoha [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-27 12:01 mbroz 2012-03-27 11:43 mbroz 2012-03-26 20:31 mbroz 2011-12-08 18:06 agk 2011-10-11 8:51 zkabelac 2011-09-21 16:36 agk 2004-05-05 18:33 agk 2004-03-31 18:41 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20091204140318.17556.qmail@sourceware.org \ --to=prajnoha@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).