public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: mbroz@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/lib/locking cluster_locking.c
Date: Wed, 09 Dec 2009 18:28:00 -0000 [thread overview]
Message-ID: <20091209182827.31047.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: mbroz@sourceware.org 2009-12-09 18:28:27
Modified files:
lib/locking : cluster_locking.c
Log message:
Get rid of magic masks in cluster locking code.
Patch should not cause any problems, only real change is
removing LCK_LOCAL bit from lock type flag, it is never used there.
(LCK_LOCAL is part arg[1] bits anyway.)
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/locking/cluster_locking.c.diff?cvsroot=lvm2&r1=1.37&r2=1.38
--- LVM2/lib/locking/cluster_locking.c 2009/12/09 18:16:38 1.37
+++ LVM2/lib/locking/cluster_locking.c 2009/12/09 18:28:27 1.38
@@ -317,8 +317,9 @@
args = alloca(len);
strcpy(args + 2, name);
- args[0] = flags & 0x7F; /* Maskoff lock flags */
- args[1] = flags & 0xC0; /* Bitmap flags */
+ /* Maskoff lock flags */
+ args[0] = flags & (LCK_SCOPE_MASK | LCK_TYPE_MASK | LCK_NONBLOCK | LCK_HOLD);
+ args[1] = flags & (LCK_LOCAL | LCK_CLUSTER_VG);
if (mirror_in_sync())
args[1] |= LCK_MIRROR_NOSYNC_MODE;
next reply other threads:[~2009-12-09 18:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 18:28 mbroz [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-08 18:19 agk
2011-11-30 17:02 mornfall
2011-02-02 23:57 agk
2011-02-01 17:31 jbrassow
2010-11-29 11:13 zkabelac
2009-12-09 18:16 mbroz
2008-12-16 12:30 wysochanski
2006-05-12 13:33 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091209182827.31047.qmail@sourceware.org \
--to=mbroz@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).