public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/metadata.c Date: Tue, 05 Jan 2010 16:01:00 -0000 [thread overview] Message-ID: <20100105160123.1697.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2010-01-05 16:01:22 Modified files: . : WHATS_NEW lib/metadata : metadata.c Log message: Do not set precommitted flag in cache when precommitted metadata does not exist. The use_precommitted flag indicates, that we want to use precommitted metadata (used in suspend call to preload table with precommitted data). But if there are no such data, committed metadata are read but the cache still contains that precommitted flag. (The problem is that later possible drop_metadata call will not invalidate device in cache.) The wrong precommitted state is stored in on remote nodes during normal suspend/resume cycle _without_ vg_write/commit. Use the PRECOMMITTED status flag here instead (which is always set if using precommited metadata here). Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1355&r2=1.1356 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.306&r2=1.307 --- LVM2/WHATS_NEW 2010/01/05 15:58:11 1.1355 +++ LVM2/WHATS_NEW 2010/01/05 16:01:22 1.1356 @@ -1,5 +1,6 @@ Version 2.02.57 - ==================================== + Properly handle precommitted flag in cache when commited data only present. Resume renamed volumes in reverse order to preserve memlock pairing. Drop metadata cache after device was autorepaired and removed from VG. Remove missing flag in metadata if PV reappeared and is empty. --- LVM2/lib/metadata/metadata.c 2009/12/18 12:45:41 1.306 +++ LVM2/lib/metadata/metadata.c 2010/01/05 16:01:22 1.307 @@ -2620,7 +2620,11 @@ if (!inconsistent_pvs) { log_debug("Updating cache for PVs without mdas " "in VG %s.", vgname); - lvmcache_update_vg(correct_vg, use_precommitted); + /* + * If there is no precommitted metadata, committed metadata + * is read and stored in the cache even if use_precommitted is set + */ + lvmcache_update_vg(correct_vg, correct_vg->status & PRECOMMITTED); if (!(pvids = lvmcache_get_pvids(cmd, vgname, vgid))) return_NULL; @@ -2721,7 +2725,11 @@ return_NULL; } - lvmcache_update_vg(correct_vg, use_precommitted); + /* + * If there is no precommitted metadata, committed metadata + * is read and stored in the cache even if use_precommitted is set + */ + lvmcache_update_vg(correct_vg, correct_vg->status & PRECOMMITTED); if (inconsistent) { /* FIXME Test should be if we're *using* precommitted metadata not if we were searching for it */
next reply other threads:[~2010-01-05 16:01 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-05 16:01 mbroz [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-12 14:18 zkabelac 2012-02-23 0:11 agk 2012-02-13 11:01 zkabelac 2012-02-13 10:58 zkabelac 2012-02-13 10:51 zkabelac 2011-11-18 19:28 zkabelac 2011-10-24 10:24 zkabelac 2011-08-11 16:31 prajnoha 2011-08-04 15:18 zkabelac 2011-03-29 21:57 zkabelac 2011-03-11 15:06 prajnoha 2011-03-10 13:12 zkabelac 2010-12-08 10:45 zkabelac 2010-11-29 11:08 zkabelac 2010-08-19 23:03 mbroz 2010-06-22 21:10 mbroz 2010-05-21 12:45 zkabelac 2010-04-01 11:43 agk 2010-03-02 21:56 snitzer 2010-01-21 21:09 wysochanski 2009-12-18 12:45 mbroz 2009-12-18 12:44 mbroz 2009-12-11 13:14 zkabelac 2009-12-09 19:29 mbroz 2009-08-20 7:03 mbroz 2009-07-16 3:25 wysochanski 2009-05-27 13:19 agk 2009-05-12 19:09 mbroz 2009-04-22 9:31 mbroz 2009-04-10 9:56 mbroz 2009-01-26 22:43 agk 2008-09-25 15:59 mbroz 2008-06-03 17:56 agk 2008-05-08 18:06 agk 2008-04-07 22:12 agk 2008-04-04 15:41 wysochanski 2007-10-12 18:37 wysochanski 2007-07-02 21:48 wysochanski 2006-09-21 20:25 agk 2006-08-09 19:33 agk 2006-07-04 19:36 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100105160123.1697.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).