public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW daemons/clvmd/lvm-functions.c ... Date: Tue, 05 Jan 2010 16:03:00 -0000 [thread overview] Message-ID: <20100105160338.27427.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2010-01-05 16:03:38 Modified files: . : WHATS_NEW daemons/clvmd : lvm-functions.c lib/locking : cluster_locking.c Log message: Properly decode flags even for VG locks. And decode flags in humar readable form in client. And clean some trailing whitespaces. No functional change in this patch (only debugging messages changed). Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1356&r2=1.1357 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/lvm-functions.c.diff?cvsroot=lvm2&r1=1.78&r2=1.79 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/locking/cluster_locking.c.diff?cvsroot=lvm2&r1=1.38&r2=1.39 --- LVM2/WHATS_NEW 2010/01/05 16:01:22 1.1356 +++ LVM2/WHATS_NEW 2010/01/05 16:03:37 1.1357 @@ -1,5 +1,6 @@ Version 2.02.57 - ==================================== + Properly decode flags even for VG locks. Properly handle precommitted flag in cache when commited data only present. Resume renamed volumes in reverse order to preserve memlock pairing. Drop metadata cache after device was autorepaired and removed from VG. --- LVM2/daemons/clvmd/lvm-functions.c 2009/12/09 19:30:56 1.78 +++ LVM2/daemons/clvmd/lvm-functions.c 2010/01/05 16:03:37 1.79 @@ -74,23 +74,23 @@ const char *command; switch (cmdl & LCK_TYPE_MASK) { - case LCK_NULL: - type = "NULL"; + case LCK_NULL: + type = "NULL"; break; - case LCK_READ: - type = "READ"; + case LCK_READ: + type = "READ"; break; - case LCK_PREAD: - type = "PREAD"; + case LCK_PREAD: + type = "PREAD"; break; - case LCK_WRITE: - type = "WRITE"; + case LCK_WRITE: + type = "WRITE"; break; - case LCK_EXCL: - type = "EXCL"; + case LCK_EXCL: + type = "EXCL"; break; - case LCK_UNLOCK: - type = "UNLOCK"; + case LCK_UNLOCK: + type = "UNLOCK"; break; default: type = "unknown"; @@ -98,34 +98,35 @@ } switch (cmdl & LCK_SCOPE_MASK) { - case LCK_VG: - scope = "VG"; + case LCK_VG: + scope = "VG"; + command = "LCK_VG"; break; - case LCK_LV: + case LCK_LV: scope = "LV"; + switch (cmdl & LCK_MASK) { + case LCK_LV_EXCLUSIVE & LCK_MASK: + command = "LCK_LV_EXCLUSIVE"; + break; + case LCK_LV_SUSPEND & LCK_MASK: + command = "LCK_LV_SUSPEND"; + break; + case LCK_LV_RESUME & LCK_MASK: + command = "LCK_LV_RESUME"; + break; + case LCK_LV_ACTIVATE & LCK_MASK: + command = "LCK_LV_ACTIVATE"; + break; + case LCK_LV_DEACTIVATE & LCK_MASK: + command = "LCK_LV_DEACTIVATE"; + break; + default: + command = "unknown"; + break; + } break; default: scope = "unknown"; - break; - } - - switch (cmdl & LCK_MASK) { - case LCK_LV_EXCLUSIVE & LCK_MASK: - command = "LCK_LV_EXCLUSIVE"; - break; - case LCK_LV_SUSPEND & LCK_MASK: - command = "LCK_LV_SUSPEND"; - break; - case LCK_LV_RESUME & LCK_MASK: - command = "LCK_LV_RESUME"; - break; - case LCK_LV_ACTIVATE & LCK_MASK: - command = "LCK_LV_ACTIVATE"; - break; - case LCK_LV_DEACTIVATE & LCK_MASK: - command = "LCK_LV_DEACTIVATE"; - break; - default: command = "unknown"; break; } --- LVM2/lib/locking/cluster_locking.c 2009/12/09 18:28:27 1.38 +++ LVM2/lib/locking/cluster_locking.c 2010/01/05 16:03:37 1.39 @@ -450,12 +450,13 @@ return 0; } - log_very_verbose("Locking %s %s %s %s%s%s%s (0x%x)", lock_scope, lockname, - lock_type, - flags & LCK_NONBLOCK ? "" : "B", - flags & LCK_HOLD ? "H" : "", - flags & LCK_LOCAL ? "L" : "", - flags & LCK_CLUSTER_VG ? "C" : "", + log_very_verbose("Locking %s %s %s (%s%s%s%s%s%s) (0x%x)", lock_scope, lockname, + lock_type, lock_scope, + flags & LCK_NONBLOCK ? "|NONBLOCK" : "", + flags & LCK_HOLD ? "|HOLD" : "", + flags & LCK_LOCAL ? "|LOCAL" : "", + flags & LCK_CLUSTER_VG ? "|CLUSTER" : "", + flags & LCK_CACHE ? "|CACHE" : "", flags); /* Send a message to the cluster manager */
next reply other threads:[~2010-01-05 16:03 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-05 16:03 mbroz [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-01-20 0:27 jbrassow 2011-12-08 21:24 agk 2011-09-27 22:43 agk 2011-08-10 20:25 zkabelac 2011-02-18 14:16 zkabelac 2011-02-18 0:36 jbrassow 2011-02-04 20:30 jbrassow 2011-02-03 16:03 zkabelac 2011-02-03 1:58 zkabelac 2010-12-08 20:51 agk 2010-11-23 1:56 agk 2010-03-26 15:40 snitzer 2010-03-23 22:30 snitzer 2010-01-19 13:25 mbroz 2010-01-05 16:09 mbroz 2010-01-05 16:06 mbroz 2009-11-23 10:44 mbroz 2009-07-24 18:15 agk 2009-07-16 0:37 agk 2009-07-15 23:57 agk 2009-07-13 19:49 agk 2009-06-12 8:30 mbroz 2009-02-22 21:14 agk 2009-01-26 19:01 agk 2008-09-19 6:42 agk 2007-08-07 9:06 meyering 2007-01-25 14:37 agk 2007-01-23 15:58 agk 2007-01-19 22:21 agk 2006-05-11 19:05 agk 2006-03-09 22:34 agk 2005-08-14 23:18 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100105160338.27427.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).