public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW daemons/clvmd/clvmd-command.c ... Date: Tue, 05 Jan 2010 16:05:00 -0000 [thread overview] Message-ID: <20100105160513.12547.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2010-01-05 16:05:12 Modified files: . : WHATS_NEW daemons/clvmd : clvmd-command.c lvm-functions.c lvm-functions.h Log message: Move processing of VG locks to separate function (similar to LV locks). And print some debugging info. No functional change in this patch. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1357&r2=1.1358 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd-command.c.diff?cvsroot=lvm2&r1=1.29&r2=1.30 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/lvm-functions.c.diff?cvsroot=lvm2&r1=1.79&r2=1.80 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/lvm-functions.h.diff?cvsroot=lvm2&r1=1.11&r2=1.12 --- LVM2/WHATS_NEW 2010/01/05 16:03:37 1.1357 +++ LVM2/WHATS_NEW 2010/01/05 16:05:12 1.1358 @@ -1,5 +1,6 @@ Version 2.02.57 - ==================================== + Move processing of VG locks to separate function in clvmd. Properly decode flags even for VG locks. Properly handle precommitted flag in cache when commited data only present. Resume renamed volumes in reverse order to preserve memlock pairing. --- LVM2/daemons/clvmd/clvmd-command.c 2009/12/09 18:42:03 1.29 +++ LVM2/daemons/clvmd/clvmd-command.c 2010/01/05 16:05:12 1.30 @@ -119,15 +119,12 @@ break; case CLVMD_CMD_LOCK_VG: + lock_cmd = args[0]; + lock_flags = args[1]; lockname = &args[2]; /* Check to see if the VG is in use by LVM1 */ status = do_check_lvm1(lockname); - /* P_#global causes a full cache refresh */ - if (!strcmp(lockname, "P_" VG_GLOBAL)) - do_refresh_cache(); - else - drop_metadata(lockname + 2); - + do_lock_vg(lock_cmd, lock_flags, lockname); break; case CLVMD_CMD_LOCK_LV: --- LVM2/daemons/clvmd/lvm-functions.c 2010/01/05 16:03:37 1.79 +++ LVM2/daemons/clvmd/lvm-functions.c 2010/01/05 16:05:12 1.80 @@ -676,12 +676,23 @@ } /* - * Drop lvmcache metadata + * Handle VG lock - drop metadata or update lvmcache state */ -void drop_metadata(const char *vgname) +void do_lock_vg(unsigned char command, unsigned char lock_flags, char *resource) { - DEBUGLOG("Dropping metadata for VG %s\n", vgname); + char *vgname = resource + 2; + + DEBUGLOG("do_lock_vg: resource '%s', cmd = %s, flags = %s, memlock = %d\n", + resource, decode_locking_cmd(command), decode_flags(lock_flags), memlock()); + + /* P_#global causes a full cache refresh */ + if (!strcmp(resource, "P_" VG_GLOBAL)) { + do_refresh_cache(); + return; + } + pthread_mutex_lock(&lvm_lock); + DEBUGLOG("Dropping metadata for VG %s\n", vgname); lvmcache_drop_metadata(vgname); pthread_mutex_unlock(&lvm_lock); } --- LVM2/daemons/clvmd/lvm-functions.h 2009/06/15 12:15:23 1.11 +++ LVM2/daemons/clvmd/lvm-functions.h 2010/01/05 16:05:12 1.12 @@ -35,6 +35,7 @@ extern int hold_unlock(char *resource); extern int hold_lock(char *resource, int mode, int flags); extern char *get_last_lvm_error(void); -extern void drop_metadata(const char *vgname); +extern void do_lock_vg(unsigned char command, unsigned char lock_flags, + char *resource); #endif
next reply other threads:[~2010-01-05 16:05 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-05 16:05 mbroz [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-09-26 7:51 zkabelac 2011-06-01 21:16 agk 2011-04-08 14:40 zkabelac 2011-02-18 16:18 zkabelac 2011-02-04 19:18 zkabelac 2011-01-31 19:52 zkabelac 2011-01-17 23:13 mbroz 2011-01-10 14:02 zkabelac 2010-06-17 12:48 mbroz 2010-06-04 12:59 mbroz 2010-01-05 16:07 mbroz 2009-12-09 18:42 mbroz 2009-04-22 9:40 mbroz 2008-05-09 18:45 agk 2008-05-09 15:13 agk 2008-04-15 14:46 mbroz 2008-04-15 11:36 agk 2006-12-11 14:00 pcaulfield 2006-10-05 13:55 pcaulfield 2006-05-12 19:16 agk 2005-10-16 23:04 agk 2005-08-16 8:25 pcaulfield
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100105160513.12547.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).