public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/filters/filter-persistent.c Date: Wed, 06 Jan 2010 13:25:00 -0000 [thread overview] Message-ID: <20100106132537.20443.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2010-01-06 13:25:36 Modified files: . : WHATS_NEW lib/filters : filter-persistent.c Log message: Use fixed buffer to prevent stack overflow in persistent filter dump. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1364&r2=1.1365 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/filters/filter-persistent.c.diff?cvsroot=lvm2&r1=1.39&r2=1.40 --- LVM2/WHATS_NEW 2010/01/05 21:32:59 1.1364 +++ LVM2/WHATS_NEW 2010/01/06 13:25:36 1.1365 @@ -1,5 +1,6 @@ Version 2.02.57 - ==================================== + Use fixed buffer to prevent stack overflow in persistent filter dump. Use snapshot metadata usage to determine if a snapshot is empty. Insert missing stack macros to all activate_lv and deactivate_lv callers. Insert missing stack macros to all suspend_lv and resume_lv callers. --- LVM2/lib/filters/filter-persistent.c 2009/12/11 13:16:38 1.39 +++ LVM2/lib/filters/filter-persistent.c 2010/01/06 13:25:36 1.40 @@ -143,7 +143,7 @@ { void *d; int first = 1; - char *buf, *str; + char buf[2 * PATH_MAX]; struct dm_hash_node *n; for (n = dm_hash_get_first(pf->devices); n; @@ -160,13 +160,8 @@ first = 0; } - str = dm_hash_get_key(pf->devices, n); - if (!(buf = alloca(escaped_len(str)))) { - log_error("persistent filter device path stack " - "allocation failed"); - return; - } - fprintf(fp, "\t\t\"%s\"", escape_double_quotes(buf, str)); + escape_double_quotes(buf, dm_hash_get_key(pf->devices, n)); + fprintf(fp, "\t\t\"%s\"", buf); } if (!first)
next reply other threads:[~2010-01-06 13:25 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-06 13:25 mbroz [this message] 2010-06-01 19:02 agk 2011-05-12 12:42 prajnoha
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100106132537.20443.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).