public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: jbrassow@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools lvconvert.c Date: Thu, 07 Jan 2010 20:42:00 -0000 [thread overview] Message-ID: <20100107204256.10272.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: jbrassow@sourceware.org 2010-01-07 20:42:56 Modified files: tools : lvconvert.c Log message: The patch fixes some lvconvert issues (WRT mirror <-> mirror). The default log option for a mirror is 'disk'. If the log type is not explicitly stated on the command line when converting from an X-way mirror to a Y-way mirror, 'disk' is chosen. So, if you have a 'core' log mirror and you convert, your result will contain a 'disk' log. This patch remembers what the old log type was. If the user is merely trying to switch the number of mirror images, the log type is now kept the same. There is one historical behaviour I left in place... If you have a 2-way, core-log mirror and you use lvconvert to specify you want a 2-way mirror - without specifying the log type - you will get a 2-way, disk-log mirror. Signed-off-by: Jonathan Brassow <jbrassow@redhat.com> Informal-IRC-ACK-by: agk Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvconvert.c.diff?cvsroot=lvm2&r1=1.101&r2=1.102 --- LVM2/tools/lvconvert.c 2010/01/06 13:27:07 1.101 +++ LVM2/tools/lvconvert.c 2010/01/07 20:42:55 1.102 @@ -628,6 +628,17 @@ return 0; } + /* + * If we are converting from one type of mirror to another, and + * the type of log wasn't specified, then let's keep the log type + * the same. + */ + if (existing_mirrors && lp->mirrors && + (lp->mirrors != existing_mirrors) && + !arg_count(cmd, mirrorlog_ARG) && !arg_count(cmd, corelog_ARG)) { + corelog = first_seg(lv)->log_lv ? 0 : 1; + } + if (repair) { cmd->handles_missing_pvs = 1; cmd->partial_activation = 1;
next reply other threads:[~2010-01-07 20:42 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-07 20:42 jbrassow [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-04-19 21:50 jbrassow 2012-02-23 22:36 zkabelac 2012-02-22 16:03 jbrassow 2012-02-22 15:20 jbrassow 2012-02-13 18:38 jbrassow 2012-02-13 18:36 jbrassow 2012-01-25 22:38 zkabelac 2011-12-08 18:00 agk 2011-06-29 2:06 jbrassow 2011-06-28 21:28 jbrassow 2011-01-19 19:24 jbrassow 2010-11-28 18:37 snitzer 2010-07-13 22:04 jbrassow 2010-07-13 21:53 jbrassow 2010-07-01 10:10 mornfall 2010-06-23 20:32 jbrassow 2010-04-28 17:41 jbrassow 2010-04-26 18:12 agk 2010-04-20 12:18 agk 2010-03-31 20:39 agk 2010-02-05 22:47 snitzer 2010-01-13 1:49 snitzer 2010-01-13 1:47 snitzer 2010-01-11 17:13 jbrassow 2009-10-21 22:19 jbrassow 2009-08-02 21:56 mornfall 2009-06-26 11:29 wysochanski 2009-06-10 15:27 mornfall 2009-05-19 10:27 mbroz 2009-05-19 10:12 mbroz 2008-01-16 22:54 agk 2008-01-16 19:40 agk 2008-01-16 19:16 agk 2007-12-21 1:08 agk 2007-08-01 20:54 jbrassow 2006-05-11 18:56 agk 2006-04-07 14:14 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100107204256.10272.qmail@sourceware.org \ --to=jbrassow@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).