public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mornfall@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/vgremove.c Date: Fri, 08 Jan 2010 14:03:00 -0000 [thread overview] Message-ID: <20100108140355.25433.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mornfall@sourceware.org 2010-01-08 14:03:55 Modified files: . : WHATS_NEW tools : vgremove.c Log message: Allow vgremove of a VG with PVs missing. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1373&r2=1.1374 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgremove.c.diff?cvsroot=lvm2&r1=1.58&r2=1.59 --- LVM2/WHATS_NEW 2010/01/07 20:55:01 1.1373 +++ LVM2/WHATS_NEW 2010/01/08 14:03:54 1.1374 @@ -1,5 +1,6 @@ Version 2.02.57 - ==================================== + Allow vgremove of a VG with PVs missing. Keep log type consistent when changing mirror image count. Always set environment variables for an LVM2 device in 11-dm-lvm.rules. Add activation/udev_rules config option in lvm.conf. --- LVM2/tools/vgremove.c 2009/12/03 19:18:34 1.58 +++ LVM2/tools/vgremove.c 2010/01/08 14:03:55 1.59 @@ -19,7 +19,7 @@ struct volume_group *vg, void *handle __attribute((unused))) { - unsigned lv_count; + unsigned lv_count, missing; force_t force; if (!vg_check_status(vg, EXPORTED_VG)) { @@ -31,13 +31,17 @@ force = arg_count(cmd, force_ARG); if (lv_count) { - if ((force == PROMPT) && - (yes_no_prompt("Do you really want to remove volume " - "group \"%s\" containing %u " - "logical volumes? [y/n]: ", - vg_name, lv_count) == 'n')) { - log_error("Volume group \"%s\" not removed", vg_name); - return ECMD_FAILED; + if (force == PROMPT) { + if ((missing = vg_missing_pv_count(vg))) + log_warn("WARNING: %d physical volumes are currently missing " + "from the system.", missing); + if (yes_no_prompt("Do you really want to remove volume " + "group \"%s\" containing %u " + "logical volumes? [y/n]: ", + vg_name, lv_count) == 'n') { + log_error("Volume group \"%s\" not removed", vg_name); + return ECMD_FAILED; + } } if (!remove_lvs_in_vg(cmd, vg, force)) { stack; @@ -67,6 +71,7 @@ return EINVALID_CMD_LINE; } + cmd->handles_missing_pvs = 1; ret = process_each_vg(cmd, argc, argv, READ_FOR_UPDATE, NULL, &vgremove_single);
next reply other threads:[~2010-01-08 14:03 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-08 14:03 mornfall [this message] -- strict thread matches above, loose matches on Subject: below -- 2007-03-15 14:00 mbroz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100108140355.25433.qmail@sourceware.org \ --to=mornfall@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).