public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/daemons/dmeventd libdevmapper-event.c
Date: Thu, 14 Jan 2010 10:11:00 -0000 [thread overview]
Message-ID: <20100114101127.27933.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2010-01-14 10:11:26
Modified files:
daemons/dmeventd: libdevmapper-event.c
Log message:
Cleanup gcc warning: null argument where non-null required (arg.2)
As the const declaration of execvp is a bit weird, using local
dmeventdpath string.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/libdevmapper-event.c.diff?cvsroot=lvm2&r1=1.29&r2=1.30
--- LVM2/daemons/dmeventd/libdevmapper-event.c 2009/07/13 21:26:41 1.29
+++ LVM2/daemons/dmeventd/libdevmapper-event.c 2010/01/14 10:11:26 1.30
@@ -398,6 +398,8 @@
int pid, ret = 0;
int status;
struct stat statbuf;
+ char dmeventdpath[] = DMEVENTD_PATH; /* const type for execvp */
+ char * const args[] = { dmeventdpath, NULL };
if (stat(fifos->client_path, &statbuf))
goto start_server;
@@ -437,7 +439,7 @@
log_error("Unable to fork.");
else if (!pid) {
- execvp(DMEVENTD_PATH, NULL);
+ execvp(args[0], args);
_exit(EXIT_FAILURE);
} else {
if (waitpid(pid, &status, 0) < 0)
next reply other threads:[~2010-01-14 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 10:11 zkabelac [this message]
2010-03-24 11:36 zkabelac
2011-01-06 9:45 zkabelac
2011-01-06 10:45 zkabelac
2011-07-08 12:35 agk
2012-03-01 10:41 zkabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114101127.27933.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).