public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/metadata.c Date: Thu, 21 Jan 2010 21:09:00 -0000 [thread overview] Message-ID: <20100121210923.32089.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2010-01-21 21:09:23 Modified files: . : WHATS_NEW lib/metadata : metadata.c Log message: Call _alloc_pv() inside _pv_read() and clean up error paths. We should be consistent with pv constructors so call _alloc_pv() here as we do from pv_create(). Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1397&r2=1.1398 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.311&r2=1.312 --- LVM2/WHATS_NEW 2010/01/21 17:14:18 1.1397 +++ LVM2/WHATS_NEW 2010/01/21 21:09:23 1.1398 @@ -1,5 +1,6 @@ Version 2.02.59 - =================================== + Cleanup memory initialization and freeing in pv_read() and pv_create(). Clear pointer and counters after their release in _fin_commands(). Add t-topology-support.sh and t-snapshot-merge.sh tests. Fix clvmd to never scan suspended devices. --- LVM2/lib/metadata/metadata.c 2010/01/21 21:04:44 1.311 +++ LVM2/lib/metadata/metadata.c 2010/01/21 21:09:23 1.312 @@ -3020,29 +3020,30 @@ if (label_sector && *label_sector) *label_sector = label->sector; - if (!(pv = dm_pool_zalloc(pvmem, sizeof(*pv)))) { + pv = _alloc_pv(pvmem, dev); + if (!pv) { log_error("pv allocation for '%s' failed", pv_name); return NULL; } - dm_list_init(&pv->tags); - dm_list_init(&pv->segments); - /* FIXME Move more common code up here */ if (!(info->fmt->ops->pv_read(info->fmt, pv_name, pv, mdas, scan_label_only))) { log_error("Failed to read existing physical volume '%s'", pv_name); - return NULL; + goto bad; } if (!pv->size) - return NULL; + goto bad; if (!alloc_pv_segment_whole_pv(pvmem, pv)) - return_NULL; + goto_bad; return pv; +bad: + _free_pv(pvmem, pv); + return NULL; } /* May return empty list */
next reply other threads:[~2010-01-21 21:09 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-21 21:09 wysochanski [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-12 14:18 zkabelac 2012-02-23 0:11 agk 2012-02-13 11:01 zkabelac 2012-02-13 10:58 zkabelac 2012-02-13 10:51 zkabelac 2011-11-18 19:28 zkabelac 2011-10-24 10:24 zkabelac 2011-08-11 16:31 prajnoha 2011-08-04 15:18 zkabelac 2011-03-29 21:57 zkabelac 2011-03-11 15:06 prajnoha 2011-03-10 13:12 zkabelac 2010-12-08 10:45 zkabelac 2010-11-29 11:08 zkabelac 2010-08-19 23:03 mbroz 2010-06-22 21:10 mbroz 2010-05-21 12:45 zkabelac 2010-04-01 11:43 agk 2010-03-02 21:56 snitzer 2010-01-05 16:01 mbroz 2009-12-18 12:45 mbroz 2009-12-18 12:44 mbroz 2009-12-11 13:14 zkabelac 2009-12-09 19:29 mbroz 2009-08-20 7:03 mbroz 2009-07-16 3:25 wysochanski 2009-05-27 13:19 agk 2009-05-12 19:09 mbroz 2009-04-22 9:31 mbroz 2009-04-10 9:56 mbroz 2009-01-26 22:43 agk 2008-09-25 15:59 mbroz 2008-06-03 17:56 agk 2008-05-08 18:06 agk 2008-04-07 22:12 agk 2008-04-04 15:41 wysochanski 2007-10-12 18:37 wysochanski 2007-07-02 21:48 wysochanski 2006-09-21 20:25 agk 2006-08-09 19:33 agk 2006-07-04 19:36 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100121210923.32089.qmail@sourceware.org \ --to=wysochanski@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).