public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: snitzer@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/activate dev_manager.c Date: Fri, 22 Jan 2010 13:28:00 -0000 [thread overview] Message-ID: <20100122132855.12940.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: snitzer@sourceware.org 2010-01-22 13:28:55 Modified files: lib/activate : dev_manager.c Log message: Removed inactive_table check from _lv_has_target_type. This check doesn't offer any benefit (that I can recall) and testing validates that. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/dev_manager.c.diff?cvsroot=lvm2&r1=1.175&r2=1.176 --- LVM2/lib/activate/dev_manager.c 2010/01/15 22:58:25 1.175 +++ LVM2/lib/activate/dev_manager.c 2010/01/22 13:28:54 1.176 @@ -327,7 +327,6 @@ return 0; } -/* FIXME Is there anything simpler to check for instead? */ static int _lv_has_target_type(struct dev_manager *dm, struct logical_volume *lv, const char *layer, @@ -363,8 +362,7 @@ &type, ¶ms); if (type && strncmp(type, target_type, strlen(target_type)) == 0) { - /* FIXME Why the inactive test? */ - if (info.live_table && !info.inactive_table) + if (info.live_table) r = 1; break; } @@ -1141,6 +1139,7 @@ 0, 1, 0, &dinfo, NULL) && dinfo.open_count) || (dev_manager_info(dm->mem, NULL, find_merging_cow(lv)->cow, 0, 1, 0, &dinfo, NULL) && dinfo.open_count)) { + /* FIXME Is there anything simpler to check for instead? */ if (!_lv_has_target_type(dm, lv, NULL, "snapshot-merge")) clear_snapshot_merge(lv); }
next reply other threads:[~2010-01-22 13:28 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-22 13:28 snitzer [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-13 17:59 jbrassow 2012-01-25 11:10 agk 2012-01-19 15:19 zkabelac 2011-12-21 12:55 zkabelac 2011-11-15 17:25 zkabelac 2011-11-15 17:21 zkabelac 2011-11-15 17:15 zkabelac 2011-10-28 20:34 zkabelac 2011-10-11 10:02 zkabelac 2011-10-11 9:03 zkabelac 2011-10-11 9:02 zkabelac 2011-10-11 9:01 zkabelac 2011-10-11 8:54 zkabelac 2011-10-03 18:24 zkabelac 2011-07-05 1:01 agk 2011-07-04 14:56 agk 2010-12-22 15:32 zkabelac 2010-12-20 14:04 zkabelac 2010-05-14 12:39 mbroz 2010-05-14 12:30 mbroz 2010-05-14 12:03 mbroz 2010-02-23 15:49 mornfall 2010-02-10 14:38 snitzer 2010-01-13 1:44 snitzer 2009-12-03 10:01 zkabelac 2009-12-03 9:59 zkabelac 2009-11-04 14:56 mbroz 2009-05-07 12:01 mbroz 2008-09-19 7:05 agk 2008-01-08 16:47 zkabelac 2007-12-03 18:00 agk 2007-11-29 15:04 agk 2005-11-22 19:37 agk 2005-11-09 23:56 agk 2005-11-09 18:12 agk 2005-11-09 13:08 agk 2005-10-26 19:50 agk 2005-10-26 17:56 agk 2005-10-26 17:31 agk 2005-10-26 15:54 agk 2005-10-26 15:00 agk 2005-10-26 14:13 agk 2005-10-17 19:06 agk 2005-08-04 1:29 agk 2004-05-12 20:40 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100122132855.12940.qmail@sourceware.org \ --to=snitzer@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).