public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: jbrassow@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW daemons/cmirrord/cluster.c Date: Wed, 27 Jan 2010 22:28:00 -0000 [thread overview] Message-ID: <20100127222806.5541.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: jbrassow@sourceware.org 2010-01-27 22:28:06 Modified files: . : WHATS_NEW daemons/cmirrord: cluster.c Log message: Was using dm_list_iterate_items when I should have been using *_safe. This had the effect of segfaulting the log daemon when converting a mirror from one log type to another. Signed-off-by: Jonathan Brassow <jbrassow@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1412&r2=1.1413 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/cmirrord/cluster.c.diff?cvsroot=lvm2&r1=1.13&r2=1.14 --- LVM2/WHATS_NEW 2010/01/27 13:29:11 1.1412 +++ LVM2/WHATS_NEW 2010/01/27 22:28:05 1.1413 @@ -1,5 +1,6 @@ Version 2.02.60 - 23rd January 2010 =================================== + Fix lvconvert issue with cluster mirrors due to un'_safe' list processing Fix pvmove abort workaround to be cluster-aware when temporary mirror activation fails. Always query device by using uuid only and not name in clvmd. Add missing metadata reverts in pvmove error path. --- LVM2/daemons/cmirrord/cluster.c 2010/01/20 02:43:19 1.13 +++ LVM2/daemons/cmirrord/cluster.c 2010/01/27 22:28:06 1.14 @@ -858,9 +858,9 @@ static int do_cluster_work(void *data __attribute((unused))) { int r = SA_AIS_OK; - struct clog_cpg *entry; + struct clog_cpg *entry, *tmp; - dm_list_iterate_items(entry, &clog_cpg_list) { + dm_list_iterate_items_safe(entry, tmp, &clog_cpg_list) { r = cpg_dispatch(entry->handle, CPG_DISPATCH_ALL); if (r != SA_AIS_OK) LOG_ERROR("cpg_dispatch failed: %s", str_ais_error(r));
next reply other threads:[~2010-01-27 22:28 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-27 22:28 jbrassow [this message] 2010-10-25 12:59 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100127222806.5541.qmail@sourceware.org \ --to=jbrassow@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).