public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: wysochanski@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/tools vgcreate.c
Date: Wed, 24 Feb 2010 18:15:00 -0000 [thread overview]
Message-ID: <20100224181541.14529.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: wysochanski@sourceware.org 2010-02-24 18:15:40
Modified files:
tools : vgcreate.c
Log message:
Refactor vgcreate to call new vg_change_tag() function.
Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgcreate.c.diff?cvsroot=lvm2&r1=1.77&r2=1.78
--- LVM2/tools/vgcreate.c 2009/12/28 18:34:45 1.77
+++ LVM2/tools/vgcreate.c 2010/02/24 18:15:40 1.78
@@ -94,16 +94,8 @@
goto bad;
}
- if (!(vg->fid->fmt->features & FMT_TAGS)) {
- log_error("Volume group format does not support tags");
- goto bad;
- }
-
- if (!str_list_add(cmd->mem, &vg->tags, tag)) {
- log_error("Failed to add tag %s to volume group %s",
- tag, vp_new.vg_name);
- goto bad;
- }
+ if (!vg_change_tag(vg, tag, 1))
+ goto_bad;
}
if (vg_is_clustered(vg)) {
next reply other threads:[~2010-02-24 18:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 18:15 wysochanski [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-12-28 18:34 mbroz
2009-10-31 17:39 wysochanski
2009-06-09 14:30 wysochanski
2004-03-26 15:46 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100224181541.14529.qmail@sourceware.org \
--to=wysochanski@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).