From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32475 invoked by alias); 31 Mar 2010 17:20:45 -0000 Received: (qmail 32461 invoked by uid 9664); 31 Mar 2010 17:20:45 -0000 Date: Wed, 31 Mar 2010 17:20:00 -0000 Message-ID: <20100331172045.32459.qmail@sourceware.org> From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/cache/lvmcache.c Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00110.txt.bz2 CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2010-03-31 17:20:44 Modified files: . : WHATS_NEW lib/cache : lvmcache.c Log message: Remove vg_validate call when parsing cached metadata. vg_validate call is an adept to optimisation, it is very ineeficient and slow. Anyway, we should call it only before writing data to disk. The call in lvmcache was just temporary validation, we realy do not need to revalidate cached metadata every time. (Actually, I added that there just to prove that cache works properly and forgot to remove it.) Patch removes it from lvmcache completely, this can hit only internal bug in export function (and this bug must be detected in any vg_write call anyway before). Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1493&r2=1.1494 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/cache/lvmcache.c.diff?cvsroot=lvm2&r1=1.82&r2=1.83 --- LVM2/WHATS_NEW 2010/03/31 17:20:02 1.1493 +++ LVM2/WHATS_NEW 2010/03/31 17:20:44 1.1494 @@ -1,5 +1,6 @@ Version 2.02.63 - ================================ + Remove vg_validate call when parsing cached metadata. Use hash table of LVs to speed up parsing of text metadata with many LVs. Fix two messages, add a whitespace and parentheses When dmeventd is not forking because of -d flag, don't kill the parent process --- LVM2/lib/cache/lvmcache.c 2010/03/17 02:11:18 1.82 +++ LVM2/lib/cache/lvmcache.c 2010/03/31 17:20:44 1.83 @@ -610,8 +610,7 @@ vgid, NULL))) return_NULL; - if (!(vg = import_vg_from_buffer(vginfo->vgmetadata, fid)) || - !vg_validate(vg)) { + if (!(vg = import_vg_from_buffer(vginfo->vgmetadata, fid))) { _free_cached_vgmetadata(vginfo); vg_release(vg); return_NULL;