From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-2942-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 17961 invoked by alias); 13 Apr 2010 07:02:15 -0000
Received: (qmail 17789 invoked by uid 9699); 13 Apr 2010 07:02:15 -0000
Date: Tue, 13 Apr 2010 07:02:00 -0000
Message-ID: <20100413070215.17786.qmail@sourceware.org>
From: mornfall@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/test test-utils.sh
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00061.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	mornfall@sourceware.org	2010-04-13 07:02:15

Modified files:
	test           : test-utils.sh 

Log message:
	Disable the rather-dangerous prepare_scsi_debug_dev in the testsuite.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/test-utils.sh.diff?cvsroot=lvm2&r1=1.34&r2=1.35

--- LVM2/test/test-utils.sh	2010/04/13 06:24:20	1.34
+++ LVM2/test/test-utils.sh	2010/04/13 07:02:14	1.35
@@ -194,6 +194,12 @@
 # - scripts must take care not to use a DEV_SIZE that will enduce OOM-killer
 prepare_scsi_debug_dev()
 {
+    # FIXME this is extremely fragile and can cause data loss if an unrelated
+    # SCSI device appears at a wrong time... we need the code to reliably
+    # identify the scsi_debug device it has created before we can re-include
+    # this in the testsuite
+    exit 200
+
     local DEV_SIZE="$1"
     shift
     local SCSI_DEBUG_PARAMS="$@"