public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
* LVM2 ./WHATS_NEW lib/locking/cluster_locking.c
@ 2010-04-13 14:36 mbroz
  0 siblings, 0 replies; 6+ messages in thread
From: mbroz @ 2010-04-13 14:36 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	mbroz@sourceware.org	2010-04-13 14:36:25

Modified files:
	.              : WHATS_NEW 
	lib/locking    : cluster_locking.c 

Log message:
	Mask LCK_HOLD flag in cluster VG locks for compatibility reasons.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1512&r2=1.1513
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/locking/cluster_locking.c.diff?cvsroot=lvm2&r1=1.41&r2=1.42

--- LVM2/WHATS_NEW	2010/04/13 01:54:32	1.1512
+++ LVM2/WHATS_NEW	2010/04/13 14:36:24	1.1513
@@ -1,5 +1,6 @@
 Version 2.02.63 -  
 ================================
+  Mask LCK_HOLD flag in cluster VG locks for compatibility reasons.
   Add activation/polling_interval to lvm.conf as --interval default.
   Don't ignore error if resuming any LV fails in resume_lvs.
   Skip closing persistent filter cache file if open failed.
--- LVM2/lib/locking/cluster_locking.c	2010/03/26 15:40:14	1.41
+++ LVM2/lib/locking/cluster_locking.c	2010/04/13 14:36:25	1.42
@@ -415,6 +415,13 @@
 
 		lock_scope = "VG";
 		clvmd_cmd = CLVMD_CMD_LOCK_VG;
+		/*
+		 * Old clvmd does not expect LCK_HOLD which was already processed
+		 * in lock_vol, mask it for compatibility reasons.
+		 */
+		if (flags != LCK_VG_COMMIT && flags != LCK_VG_REVERT)
+			flags &= ~LCK_HOLD;
+
 		break;
 
 	case LCK_LV:


^ permalink raw reply	[flat|nested] 6+ messages in thread

* LVM2 ./WHATS_NEW lib/locking/cluster_locking.c
@ 2012-03-26 20:29 mbroz
  0 siblings, 0 replies; 6+ messages in thread
From: mbroz @ 2012-03-26 20:29 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	mbroz@sourceware.org	2012-03-26 20:29:46

Modified files:
	.              : WHATS_NEW 
	lib/locking    : cluster_locking.c 

Log message:
	Remove unused and wrongly set cluster VG flag from clvmd lock query command.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2367&r2=1.2368
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/locking/cluster_locking.c.diff?cvsroot=lvm2&r1=1.64&r2=1.65

--- LVM2/WHATS_NEW	2012/03/23 16:28:40	1.2367
+++ LVM2/WHATS_NEW	2012/03/26 20:29:45	1.2368
@@ -1,5 +1,6 @@
 Version 2.02.96 - 
 ================================
+  Remove unused and wrongly set cluster VG flag from clvmd lock query command.
   Fix pvmove for exclusively activated LV pvmove in clustered VG. (2.02.86)
   Always free hash table on update_pvid_to_vgid() in lvmetad.
   Update and fix monitoring of thin pool devices.
--- LVM2/lib/locking/cluster_locking.c	2012/01/21 05:29:52	1.64
+++ LVM2/lib/locking/cluster_locking.c	2012/03/26 20:29:46	1.65
@@ -538,7 +538,7 @@
 	strcpy(args + 2, resource);
 
 	args[0] = 0;
-	args[1] = LCK_CLUSTER_VG;
+	args[1] = 0;
 
 	status = _cluster_request(CLVMD_CMD_LOCK_QUERY, node, args, len,
 				  &response, &num_responses);


^ permalink raw reply	[flat|nested] 6+ messages in thread

* LVM2 ./WHATS_NEW lib/locking/cluster_locking.c
@ 2011-10-21 15:49 agk
  0 siblings, 0 replies; 6+ messages in thread
From: agk @ 2011-10-21 15:49 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk@sourceware.org	2011-10-21 15:49:45

Modified files:
	.              : WHATS_NEW 
	lib/locking    : cluster_locking.c 

Log message:
	Pass exclusive LV locks to all nodes in the cluster.
	This was the intended behaviour, as described in the lvchange man page, so you
	have complete control through volume_list in lvm.conf, but the code seems to
	have been treating -ae as local-only for a very long time.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2165&r2=1.2166
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/locking/cluster_locking.c.diff?cvsroot=lvm2&r1=1.59&r2=1.60

--- LVM2/WHATS_NEW	2011/10/21 09:53:16	1.2165
+++ LVM2/WHATS_NEW	2011/10/21 15:49:45	1.2166
@@ -1,5 +1,6 @@
 Version 2.02.89 - 
 ==================================
+  Pass exclusive LV locks to all nodes in the cluster.
   Improve lvcreate man documentation of the chunksize option.
   Improve man page style for lvcreate.
   Avoid recursive calls to dmeventd in its LVM plugins.
@@ -19,7 +20,7 @@
   Fix splitmirror in cluster having different DM/LVM views of storage.
   Fix improper udev settings during suspend/resume for mirror sub-LVs.
   Fix vgsplit when there are mirrors that have mirrored logs.
-  Clarify multi-name device filter pattern matching explanation in lvm.conf.5.
+  Clarify multi-name device filter pattern matching explanation in lvm.conf.
   Introduce lv_send_message and dev_manager_send_message.
   Introduce revert_lv for better pvmove cleanup.
   Replace incomplete pvmove activation failure recovery code with a message.
--- LVM2/lib/locking/cluster_locking.c	2011/09/27 22:43:41	1.59
+++ LVM2/lib/locking/cluster_locking.c	2011/10/21 15:49:45	1.60
@@ -366,7 +366,6 @@
 	} else if (clvmd_cmd != CLVMD_CMD_VG_BACKUP) {
 		if (strncmp(name, "P_", 2) &&
 		    (clvmd_cmd == CLVMD_CMD_LOCK_VG ||
-		     (flags & LCK_TYPE_MASK) == LCK_EXCL ||
 		     (flags & LCK_LOCAL) ||
 		     !(flags & LCK_CLUSTER_VG)))
 			node = ".";


^ permalink raw reply	[flat|nested] 6+ messages in thread

* LVM2 ./WHATS_NEW lib/locking/cluster_locking.c
@ 2011-02-02 23:39 agk
  0 siblings, 0 replies; 6+ messages in thread
From: agk @ 2011-02-02 23:39 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk@sourceware.org	2011-02-02 23:39:39

Modified files:
	.              : WHATS_NEW 
	lib/locking    : cluster_locking.c 

Log message:
	Allow CLVMD_CMD_SYNC_NAMES to be propagated around the cluster if requested.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1897&r2=1.1898
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/locking/cluster_locking.c.diff?cvsroot=lvm2&r1=1.51&r2=1.52

--- LVM2/WHATS_NEW	2011/02/01 21:41:31	1.1897
+++ LVM2/WHATS_NEW	2011/02/02 23:39:39	1.1898
@@ -1,5 +1,6 @@
 Version 2.02.83 - 
 ===================================
+  Allow CLVMD_CMD_SYNC_NAMES to be propagated around the cluster if requested.
   Add "dmsetup ls --tree" output to lvmdump.
   Fix udev synchronization with no-locking --sysinit (2.02.80).
   Updating man pages for pvcreate, pvremove, pvresize, pvscan.
--- LVM2/lib/locking/cluster_locking.c	2011/02/01 17:31:40	1.51
+++ LVM2/lib/locking/cluster_locking.c	2011/02/02 23:39:39	1.52
@@ -347,13 +347,17 @@
 	 * One exception, is that P_ locks (except VG_SYNC_NAMES) /do/ get 
 	 * distributed across the cluster because they might have side-effects.
 	 */
-	if ((strncmp(name, "P_", 2) &&
-	     (clvmd_cmd == CLVMD_CMD_LOCK_VG ||
-	      (flags & LCK_TYPE_MASK) == LCK_EXCL ||
-	      (flags & LCK_LOCAL) ||
-	      !(flags & LCK_CLUSTER_VG))) ||
-	    (clvmd_cmd == CLVMD_CMD_SYNC_NAMES && (flags & LCK_LOCAL)))
-		node = ".";
+	if (clvmd_cmd == CLVMD_CMD_SYNC_NAMES) {
+		if (flags & LCK_LOCAL)
+			node = ".";
+	} else if (clvmd_cmd != CLVMD_CMD_VG_BACKUP) {
+		if (strncmp(name, "P_", 2) &&
+		    (clvmd_cmd == CLVMD_CMD_LOCK_VG ||
+		     (flags & LCK_TYPE_MASK) == LCK_EXCL ||
+		     (flags & LCK_LOCAL) ||
+		     !(flags & LCK_CLUSTER_VG)))
+			node = ".";
+	}
 
 	status = _cluster_request(clvmd_cmd, node, args, len,
 				  &response, &num_responses);


^ permalink raw reply	[flat|nested] 6+ messages in thread

* LVM2 ./WHATS_NEW lib/locking/cluster_locking.c
@ 2008-04-14 19:49 agk
  0 siblings, 0 replies; 6+ messages in thread
From: agk @ 2008-04-14 19:49 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk@sourceware.org	2008-04-14 19:49:13

Modified files:
	.              : WHATS_NEW 
	lib/locking    : cluster_locking.c 

Log message:
	Don't attempt remote metadata backups of non-clustered VGs. (2.02.29)

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.848&r2=1.849
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/locking/cluster_locking.c.diff?cvsroot=lvm2&r1=1.25&r2=1.26

--- LVM2/WHATS_NEW	2008/04/14 19:24:15	1.848
+++ LVM2/WHATS_NEW	2008/04/14 19:49:12	1.849
@@ -1,5 +1,6 @@
 Version 2.02.35 - 
 =================================
+  Don't attempt remote metadata backups of non-clustered VGs. (2.02.29)
   Don't store fid in VG metadata cache to avoid clvmd segfault. (2.02.34)
   Update vgsplit tests to verify loosening of active LV restriction.
   Update vgsplit to only restrict split with active LVs involved in split.
--- LVM2/lib/locking/cluster_locking.c	2008/01/30 13:59:59	1.25
+++ LVM2/lib/locking/cluster_locking.c	2008/04/14 19:49:12	1.26
@@ -438,8 +438,10 @@
 		return 0;
 	}
 
-	/* If we are unlocking a VG, then trigger remote metadata backups */
-	if (cluster_cmd == CLVMD_CMD_LOCK_VG && ((flags & LCK_TYPE_MASK) == LCK_UNLOCK)) {
+	/* If we are unlocking a clustered VG, then trigger remote metadata backups */
+	if (cluster_cmd == CLVMD_CMD_LOCK_VG &&
+	    ((flags & LCK_TYPE_MASK) == LCK_UNLOCK) &&
+	    (flags & LCK_CLUSTER_VG)) {
 		log_very_verbose("Requesing backup of VG metadata for %s", resource);
 		_lock_for_cluster(CLVMD_CMD_VG_BACKUP, LCK_CLUSTER_VG, resource);
 	}


^ permalink raw reply	[flat|nested] 6+ messages in thread

* LVM2 ./WHATS_NEW lib/locking/cluster_locking.c
@ 2006-06-12  9:46 pcaulfield
  0 siblings, 0 replies; 6+ messages in thread
From: pcaulfield @ 2006-06-12  9:46 UTC (permalink / raw)
  To: lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	pcaulfield@sourceware.org	2006-06-12 09:46:35

Modified files:
	.              : WHATS_NEW 
	lib/locking    : cluster_locking.c 

Log message:
	Fix "Unaligned access" when using clvm
	bz#194626

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.397&r2=1.398
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/locking/cluster_locking.c.diff?cvsroot=lvm2&r1=1.12&r2=1.13

Full Patch:
--- LVM2/WHATS_NEW	2006/06/08 22:15:49	1.397
+++ LVM2/WHATS_NEW	2006/06/12 09:46:34	1.398
@@ -13,6 +13,7 @@
   Add 'Completed' debug message.
   Don't attempt library exit after reloading config files.
   Always compile with libdevmapper, even if device-mapper is disabled.
+  Fixed unaligned access when using clvm.
 
 Version 2.02.06 - 12th May 2006
 ===============================
--- LVM2/lib/locking/cluster_locking.c	2006/05/16 16:48:30	1.12
+++ LVM2/lib/locking/cluster_locking.c	2006/06/12 09:46:35	1.13
@@ -256,7 +256,7 @@
 		strcpy(rarray[i].node, inptr);
 		inptr += strlen(inptr) + 1;
 
-		rarray[i].status = *(int *) inptr;
+		memcpy(&rarray[i].status, inptr, sizeof(int));
 		inptr += sizeof(int);
 
 		rarray[i].response = dm_malloc(strlen(inptr) + 1);


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-03-26 20:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-13 14:36 LVM2 ./WHATS_NEW lib/locking/cluster_locking.c mbroz
  -- strict thread matches above, loose matches on Subject: below --
2012-03-26 20:29 mbroz
2011-10-21 15:49 agk
2011-02-02 23:39 agk
2008-04-14 19:49 agk
2006-06-12  9:46 pcaulfield

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).