public inbox for
help / color / mirror / Atom feed
Subject: LVM2/lib/metadata metadata-exported.h metadata ...
Date: Tue, 13 Apr 2010 17:25:00 -0000	[thread overview]
Message-ID: <> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	2010-04-13 17:25:45

Modified files:
	lib/metadata   : metadata-exported.h metadata.c metadata.h 

Log message:
	Add del_pvl_from_vgs() and move prototypes into metadata-exported.h
	Add a delete function to manage the vg->pvs list.
	NOTE: It may be possible to do further cleanup to these add/del functions
	by passing a 'pv' as input instead of 'pv_list'.  The pv_list is used for
	functions which do allocations (lvcreate) while other places in the code
	just manage a list of 'pv' (e.g. import functions, vgextend, etc).
	Signed-off-by: Dave Wysochanski <>


--- LVM2/lib/metadata/metadata-exported.h	2010/04/09 01:00:11	1.139
+++ LVM2/lib/metadata/metadata-exported.h	2010/04/13 17:25:44	1.140
@@ -470,6 +470,9 @@
 int vg_set_clustered(struct volume_group *vg, int clustered);
 int vg_split_mdas(struct cmd_context *cmd, struct volume_group *vg_from,
 		  struct volume_group *vg_to);
+/* FIXME: Investigate refactoring these functions to take a pv ISO pv_list */
+void add_pvl_to_vgs(struct volume_group *vg, struct pv_list *pvl);
+void del_pvl_from_vgs(struct volume_group *vg, struct pv_list *pvl);
 /* FIXME: refactor / unexport when lvremove liblvm refactoring dones */
 int remove_lvs_in_vg(struct cmd_context *cmd,
--- LVM2/lib/metadata/metadata.c	2010/04/08 15:18:35	1.332
+++ LVM2/lib/metadata/metadata.c	2010/04/13 17:25:44	1.333
@@ -145,6 +145,12 @@
+void del_pvl_from_vgs(struct volume_group *vg, struct pv_list *pvl)
+	vg->pv_count--;
+	dm_list_del(&pvl->list);
  * add_pv_to_vg - Add a physical volume to a volume group
--- LVM2/lib/metadata/metadata.h	2010/04/06 14:04:57	1.202
+++ LVM2/lib/metadata/metadata.h	2010/04/13 17:25:45	1.203
@@ -377,6 +377,5 @@
 struct physical_volume *pv_by_path(struct cmd_context *cmd, const char *pv_name);
 int add_pv_to_vg(struct volume_group *vg, const char *pv_name,
 		 struct physical_volume *pv);
-void add_pvl_to_vgs(struct volume_group *vg, struct pv_list *pvl);

             reply	other threads:[~2010-04-13 17:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-13 17:25 wysochanski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-09-25 15:57 mbroz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).