public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/lvconvert.c Date: Mon, 26 Apr 2010 18:32:00 -0000 [thread overview] Message-ID: <20100426183159.28003.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2010-04-26 18:31:59 Modified files: . : WHATS_NEW tools : lvconvert.c Log message: Fix lvconvert error message when existing mirrored LV is not found. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1537&r2=1.1538 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvconvert.c.diff?cvsroot=lvm2&r1=1.131&r2=1.132 --- LVM2/WHATS_NEW 2010/04/23 19:27:10 1.1537 +++ LVM2/WHATS_NEW 2010/04/26 18:31:58 1.1538 @@ -1,5 +1,6 @@ Version 2.02.64 - ================================= + Fix lvconvert error message when existing mirrored LV is not found. Disallow the direct removal of a merging snapshot. Set appropriate udev flags for reserved LVs. Don't preload the origin when removing a snapshot whose merge is pending. --- LVM2/tools/lvconvert.c 2010/04/26 18:12:40 1.131 +++ LVM2/tools/lvconvert.c 2010/04/26 18:31:58 1.132 @@ -1533,12 +1533,11 @@ vg = _get_lvconvert_vg(cmd, vg_name, NULL); if (vg_read_error(vg)) { vg_release(vg); - log_error("ABORTING: Can't reread VG for %s", vg_name); - return NULL; + return_NULL; } if (!(lv = _get_lvconvert_lv(cmd, vg, lv_name, NULL, 0))) { - log_error("ABORTING: Can't find LV %s in VG %s", lv_name, vg_name); + log_error("Can't find LV %s in VG %s", lv_name, vg_name); unlock_and_release_vg(cmd, vg, vg_name); return NULL; } @@ -1616,8 +1615,10 @@ vg_name = lv->vg->name; unlock_vg(cmd, vg_name); refreshed_lv = get_vg_lock_and_logical_volume(cmd, vg_name, lv->name); - if (!refreshed_lv) + if (!refreshed_lv) { + log_error("ABORTING: Can't reread LV %s/%s", vg_name, lv->name); return ECMD_FAILED; + } lp->lv_to_poll = refreshed_lv; ret = _lvconvert_single(cmd, refreshed_lv, lp);
next reply other threads:[~2010-04-26 18:32 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-04-26 18:32 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-30 8:58 prajnoha 2012-02-22 17:18 jbrassow 2011-06-01 12:24 prajnoha 2011-01-05 23:18 jbrassow 2011-01-05 20:02 jbrassow 2010-07-30 17:50 taka 2010-07-06 17:02 jbrassow 2010-02-05 21:49 jbrassow 2009-10-23 1:24 agk 2009-06-26 9:04 agk 2009-06-15 13:43 mbroz 2009-06-15 12:09 mbroz 2008-06-26 21:38 agk 2008-04-18 12:50 agk 2008-02-12 13:29 agk 2008-02-12 13:26 agk 2008-01-14 21:11 agk 2007-08-22 20:03 agk 2007-08-22 19:32 agk 2007-08-10 13:33 wysochanski 2005-08-15 14:10 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100426183159.28003.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).