public inbox for email@example.com help / color / mirror / Atom feed
From: firstname.lastname@example.org To: email@example.com, firstname.lastname@example.org Subject: LVM2 ./WHATS_NEW lib/metadata/mirror.c Date: Tue, 27 Apr 2010 14:57:00 -0000 [thread overview] Message-ID: <email@example.com> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: firstname.lastname@example.org 2010-04-27 14:57:49 Modified files: . : WHATS_NEW lib/metadata : mirror.c Log message: Patch to fix bug 586021 and mantain historical behavior of being able to remove more images from a mirror than the number of PVs directly specified for removal. The effort to fix bug 581611 corrected a bug that was unnoticed at the time. The loop in _remove_mirror_images that looks over the specified PVs was allowing devices that were previously counted and moved to the end of the list to be double-counted. This resulted in the number of devices needed for removal always being satisfied - even if the user did not specify enough PVs for removal to satisfy the request. When 581611 was fixed, this double-counting no longer took place and the result was to remove only the minimum of the number of PVs specified or the number that was asked to be removed. By simply always setting 'new_area_count' (as used to be done only in the else statement), we return to the previous behavior. Indeed, this is exactly what the double-counting was allowing to happen before the fix of 581611. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1538&r2=1.1539 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/mirror.c.diff?cvsroot=lvm2&r1=1.114&r2=1.115 --- LVM2/WHATS_NEW 2010/04/26 18:31:58 1.1538 +++ LVM2/WHATS_NEW 2010/04/27 14:57:49 1.1539 @@ -1,5 +1,6 @@ Version 2.02.64 - ================================= + Fix regression in down-convert of mirror images with partial PV specification. Fix lvconvert error message when existing mirrored LV is not found. Disallow the direct removal of a merging snapshot. Set appropriate udev flags for reserved LVs. --- LVM2/lib/metadata/mirror.c 2010/04/21 13:55:08 1.114 +++ LVM2/lib/metadata/mirror.c 2010/04/27 14:57:49 1.115 @@ -805,8 +805,15 @@ } if (num_removed && old_area_count == new_area_count) return 1; - } else - new_area_count = old_area_count - num_removed; + } + + /* + * If removable_pvs were specified, then they have been shifted + * to the end to ensure they are removed. The remaining balance + * of images left to remove will be taken from the unspecified. + * This may not be correct behavior, but it is historical. + */ + new_area_count = old_area_count - num_removed; /* Remove mimage LVs from the segment */ dm_list_init(&tmp_orphan_lvs);
next reply other threads:[~2010-04-27 14:57 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-04-27 14:57 jbrassow [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-23 16:28 mbroz 2012-02-01 13:50 zkabelac 2011-10-25 13:17 jbrassow 2011-10-06 14:49 jbrassow 2011-09-14 2:45 jbrassow 2011-09-13 21:13 jbrassow 2011-09-13 14:37 jbrassow 2011-09-13 13:59 jbrassow 2011-09-01 19:22 jbrassow 2011-06-17 14:27 zkabelac 2010-08-16 18:02 jbrassow 2010-07-13 22:24 jbrassow 2010-07-13 21:48 jbrassow 2010-07-09 15:08 jbrassow 2010-06-28 14:19 jbrassow 2010-06-21 16:12 jbrassow 2010-04-27 15:27 jbrassow 2009-12-09 19:53 mbroz 2009-12-09 18:09 mbroz 2009-04-10 9:53 mbroz 2008-10-17 10:50 agk 2008-09-18 19:09 agk 2008-06-13 12:15 meyering 2008-02-22 13:28 agk 2007-11-22 13:57 agk 2006-11-30 17:52 agk 2006-11-10 19:35 agk 2006-07-20 20:37 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).