public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/filters/filter-regex.c Date: Fri, 30 Apr 2010 12:31:00 -0000 [thread overview] Message-ID: <20100430123135.21822.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2010-04-30 12:31:33 Modified files: . : WHATS_NEW lib/filters : filter-regex.c Log message: Show string with invalid pattern and start error message with capital letter. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1542&r2=1.1543 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/filters/filter-regex.c.diff?cvsroot=lvm2&r1=1.26&r2=1.27 --- LVM2/WHATS_NEW 2010/04/29 01:45:30 1.1542 +++ LVM2/WHATS_NEW 2010/04/30 12:31:32 1.1543 @@ -1,5 +1,6 @@ Version 2.02.64 - ================================= + Display invalid regex pattern for filter configuration in case of error. Remove no-longer-used arg_ptr_value. Fix -M and --type to use strings not pointers that change on config refresh. Fix lvconvert error message when existing mirrored LV is not found. --- LVM2/lib/filters/filter-regex.c 2008/11/03 22:14:28 1.26 +++ LVM2/lib/filters/filter-regex.c 2010/04/30 12:31:33 1.27 @@ -103,7 +103,7 @@ */ for (v = val; v; v = v->next) { if (v->type != CFG_STRING) { - log_error("filter patterns must be enclosed in quotes"); + log_error("Filter patterns must be enclosed in quotes."); goto out; } @@ -128,7 +128,7 @@ */ for (v = val, i = count - 1; v; v = v->next, i--) if (!_extract_pattern(scratch, v->v.str, regex, rf->accept, i)) { - log_error("invalid filter pattern"); + log_error("Invalid filter pattern \"%s\".", v->v.str); goto out; }
next reply other threads:[~2010-04-30 12:31 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-04-30 12:31 zkabelac [this message] 2010-12-20 13:45 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100430123135.21822.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).