From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-3058-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 5442 invoked by alias); 12 May 2010 05:55:44 -0000
Received: (qmail 5428 invoked by uid 9699); 12 May 2010 05:55:44 -0000
Date: Wed, 12 May 2010 05:55:00 -0000
Message-ID: <20100512055544.5426.qmail@sourceware.org>
From: mornfall@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/test not.c
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00021.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	mornfall@sourceware.org	2010-05-12 05:55:42

Modified files:
	test           : not.c 

Log message:
	The "should" testing utility should actually only give a warning when the
	command fails.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/not.c.diff?cvsroot=lvm2&r1=1.3&r2=1.4

--- LVM2/test/not.c	2010/04/30 14:33:39	1.3
+++ LVM2/test/not.c	2010/05/12 05:55:42	1.4
@@ -8,7 +8,8 @@
 	if (!strcmp(cmd, "not"))
 		return !status;
 	if (!strcmp(cmd, "should")) {
-		fprintf(stderr, "TEST WARNING: Ignoring command failure.\n");
+		if (status)
+			fprintf(stderr, "TEST WARNING: Ignoring command failure.\n");
 		return 0;
 	}
 	return 6;