public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: jbrassow@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/mirror.c Date: Mon, 21 Jun 2010 16:12:00 -0000 [thread overview] Message-ID: <20100621161234.18085.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: jbrassow@sourceware.org 2010-06-21 16:12:34 Modified files: . : WHATS_NEW lib/metadata : mirror.c Log message: Mirrors can be layered - as in the case of an converting 2-way to 3-way mirror. When conversion operations are performed on these types of mirrors, log options can be confused/ignored. In the case of a converting 3-way mirror, we have a top-level 2-way corelog mirror whose legs are 1) a 2-way disk-log mirror and 2) a linear device. If we wish to convert this 3-way mirror to a 2-way mirror, the linear device is removed and the extra top layer is eliminated. If we also wished to convert the disk log to a core log in the same step, ambiguity creeps in. It is somewhat obvious what the user wants - a 2-way mirror with a corelog. However, looking at the top level mirror before compression, it seems that the mirror already has a core log. This is why the operation seemed to fail. This patch simply re-evaluates what mirrored_seg points to after a compression and then considers the log argument. This is a fix for bug 599898. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1622&r2=1.1623 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/mirror.c.diff?cvsroot=lvm2&r1=1.118&r2=1.119 --- LVM2/WHATS_NEW 2010/06/21 15:56:57 1.1622 +++ LVM2/WHATS_NEW 2010/06/21 16:12:33 1.1623 @@ -1,5 +1,6 @@ Version 2.02.68 - =============================== + Honor log argument when down-converting stacked mirror. Sleep to workaround clvmd -S race: socket closed early and server drops cmd. Use early udev synchronisation and update of dev nodes for clustered mirrors. Remove incorrect inclusion of kdev_t.h from cmirrord/functions.h. --- LVM2/lib/metadata/mirror.c 2010/05/24 15:32:20 1.118 +++ LVM2/lib/metadata/mirror.c 2010/06/21 16:12:34 1.119 @@ -851,6 +851,9 @@ log_error("Failed to add mirror images"); return 0; } + mirrored_seg = first_seg(lv); + if (remove_log && !detached_log_lv) + detached_log_lv = detach_mirror_log(mirrored_seg); } else if (new_area_count == 0) { log_very_verbose("All mimages of %s are gone", lv->name);
next reply other threads:[~2010-06-21 16:12 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-06-21 16:12 jbrassow [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-23 16:28 mbroz 2012-02-01 13:50 zkabelac 2011-10-25 13:17 jbrassow 2011-10-06 14:49 jbrassow 2011-09-14 2:45 jbrassow 2011-09-13 21:13 jbrassow 2011-09-13 14:37 jbrassow 2011-09-13 13:59 jbrassow 2011-09-01 19:22 jbrassow 2011-06-17 14:27 zkabelac 2010-08-16 18:02 jbrassow 2010-07-13 22:24 jbrassow 2010-07-13 21:48 jbrassow 2010-07-09 15:08 jbrassow 2010-06-28 14:19 jbrassow 2010-04-27 15:27 jbrassow 2010-04-27 14:57 jbrassow 2009-12-09 19:53 mbroz 2009-12-09 18:09 mbroz 2009-04-10 9:53 mbroz 2008-10-17 10:50 agk 2008-09-18 19:09 agk 2008-06-13 12:15 meyering 2008-02-22 13:28 agk 2007-11-22 13:57 agk 2006-11-30 17:52 agk 2006-11-10 19:35 agk 2006-07-20 20:37 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100621161234.18085.qmail@sourceware.org \ --to=jbrassow@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).