public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: mornfall@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/test t-lvconvert-mirror-basic.sh
Date: Mon, 28 Jun 2010 19:13:00 -0000	[thread overview]
Message-ID: <20100628191334.22782.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	mornfall@sourceware.org	2010-06-28 19:13:34

Modified files:
	test           : t-lvconvert-mirror-basic.sh 

Log message:
	Minor shell style cleanup.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/t-lvconvert-mirror-basic.sh.diff?cvsroot=lvm2&r1=1.2&r2=1.3

--- LVM2/test/t-lvconvert-mirror-basic.sh	2010/05/12 13:15:38	1.2
+++ LVM2/test/t-lvconvert-mirror-basic.sh	2010/06/28 19:13:33	1.3
@@ -2,9 +2,9 @@
 
 log_name_to_count()
 {
-	if [ $1 == "mirrored" ]; then
+	if [ "$1" = "mirrored" ]; then
 		echo 2
-	elif [ $1 == "disk" ]; then
+	elif [ "$1" = "disk" ]; then
 		echo 1
 	else
 		echo 0
@@ -44,8 +44,8 @@
 	local active=true
 	local i
 
-	if [ $start_log_type == "disk" ] &&
-		[ $finish_log_type == "mirrored" ]; then
+	if [ "$start_log_type" = "disk" ] &&
+		[ "$finish_log_type" = "mirrored" ]; then
 		echo "FIXME:  disk -> mirrored log conversion not yet supported by LVM"
 		return 0
 	fi


             reply	other threads:[~2010-06-28 19:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-28 19:13 mornfall [this message]
2011-01-28 16:07 zkabelac
2011-03-03 12:30 zkabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100628191334.22782.qmail@sourceware.org \
    --to=mornfall@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).